From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54838 invoked by alias); 3 Nov 2015 13:26:14 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 54812 invoked by uid 89); 3 Nov 2015 13:26:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: userp1040.oracle.com Received: from userp1040.oracle.com (HELO userp1040.oracle.com) (156.151.31.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 03 Nov 2015 13:26:07 +0000 Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id tA3DQ5I7014671 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 3 Nov 2015 13:26:05 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id tA3DQ50o020379 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Tue, 3 Nov 2015 13:26:05 GMT Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by userv0122.oracle.com (8.13.8/8.13.8) with ESMTP id tA3DQ4NI007350; Tue, 3 Nov 2015 13:26:05 GMT Received: from [192.168.1.4] (/87.3.196.211) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 03 Nov 2015 05:26:04 -0800 Subject: Re: [PATCH] Add configure flag for operator new (std::nothrow) To: Aurelio Remonda , libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org References: <1446554133-3090-1-git-send-email-aurelio.remonda@tallertechnologies.com> Cc: daniel.gutston@tallertechnologies.com, jwakely.gcc@gmail.com From: Paolo Carlini Message-ID: <5638B5EA.9080303@oracle.com> Date: Tue, 03 Nov 2015 13:26:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1446554133-3090-1-git-send-email-aurelio.remonda@tallertechnologies.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00195.txt.bz2 Hi, On 11/03/2015 01:35 PM, Aurelio Remonda wrote: > diff --git a/ChangeLog b/ChangeLog > index 5b16ca2..a1cd0d3 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,3 +1,12 @@ > +2015-10-30 Aurelio Remonda > + > + * libstdc++-v3/acinclude.m4: add enable_new_opnt_no_allocation_retry > + flag definition. > + * libstdc++-v3/configure.ac: add option flag > + GLIBCXX_ENABLE_NEW_OPNT_NO_ALLOCATION_RETRY > + * libstdc++-v3/libsupc++/new_opnt.cc use the defined macro > + * libstdc++-v3/doc/xml/manual/configure.xml > + Three minor comments. First, ChangeLog entries aren't normally submitted as part of the patch. Second, since the ChangeLog is under libstdc++-v3, the ChangeLog entries should not have libstdc++-v3 in the paths (eg, just * acinclude.m4: ...). Finally, since you are touching acinclude.m4 you should normally run autoreconf, mention in the ChangeLog the changed regenerated files and eventually commit those changes too (like the ChangeLog entries, those aren't normally part of the posted patch) About the three issues, you have plenty of examples in the mailing list. Otherwise, about the substance of the patch, I think we want to wait for Jonathan to be back. Paolo.