From: Nathan Sidwell <nathan@acm.org>
To: Jakub Jelinek <jakub@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [1/2] OpenACC routine support
Date: Tue, 03 Nov 2015 15:55:00 -0000 [thread overview]
Message-ID: <5638D8EB.6070405@acm.org> (raw)
In-Reply-To: <20151103153533.GQ478@tucnak.redhat.com>
On 11/03/15 10:35, Jakub Jelinek wrote:
> On Mon, Nov 02, 2015 at 02:21:43PM -0500, Nathan Sidwell wrote:
>> --- gcc/c/c-parser.c (revision 229667)
>> +++ gcc/c/c-parser.c (working copy)
>> @@ -1160,7 +1160,8 @@ enum c_parser_prec {
>> static void c_parser_external_declaration (c_parser *);
>> static void c_parser_asm_definition (c_parser *);
>> static void c_parser_declaration_or_fndef (c_parser *, bool, bool, bool,
>> - bool, bool, tree *, vec<c_token>);
>> + bool, bool, tree *, vec<c_token>,
>> + tree);
>
> Wonder if this shouldn't be tree = NULL_TREE, then you'd avoid most of the
> c_parser_declaration_or_fndef caller changes.
yeah, I guess that'd be less invasive. I'm fine with it.
next prev parent reply other threads:[~2015-11-03 15:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 18:56 [0/2] " Nathan Sidwell
2015-11-02 19:21 ` [1/2] " Nathan Sidwell
2015-11-03 15:35 ` Jakub Jelinek
2015-11-03 15:55 ` Nathan Sidwell [this message]
2015-11-10 0:32 ` Nathan Sidwell
2015-11-10 0:48 ` Nathan Sidwell
2015-11-10 5:31 ` Cesar Philippidis
2015-11-10 5:28 ` Cesar Philippidis
2015-11-10 8:16 ` Jakub Jelinek
2015-11-10 14:37 ` Cesar Philippidis
2015-11-18 19:02 ` Cesar Philippidis
2015-11-19 11:23 ` Jakub Jelinek
2015-12-01 14:40 ` Thomas Schwinge
2015-12-01 14:49 ` Cesar Philippidis
2015-12-02 23:37 ` Cesar Philippidis
2015-12-03 8:36 ` Thomas Schwinge
2015-12-03 14:06 ` Cesar Philippidis
2015-11-02 19:23 ` [2/2] " Nathan Sidwell
2015-11-02 19:41 ` Jakub Jelinek
2015-11-02 20:01 ` Nathan Sidwell
2015-11-03 15:38 ` Jakub Jelinek
2015-11-03 15:56 ` Nathan Sidwell
2015-11-03 16:05 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5638D8EB.6070405@acm.org \
--to=nathan@acm.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).