From: "Lynn A. Boger" <laboger@linux.vnet.ibm.com>
To: Ian Lance Taylor <iant@golang.org>
Cc: Uros Bizjak <ubizjak@gmail.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"gofrontend-dev@googlegroups.com"
<gofrontend-dev@googlegroups.com>
Subject: Re: libgo patch committed: Update to Go 1.5 release
Date: Tue, 03 Nov 2015 20:17:00 -0000 [thread overview]
Message-ID: <56391669.3060408@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAOyqgcUSi967ocahBWM0zzB-pewB3S0Wq4nDFz1DqCCBVGqUvA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1866 bytes --]
I can see the problem in gotest. It has to do with the setting of GOARCH.
Previously GOARCH was being set based on the --goarch argument, but now
goarch is being set. Not sure both GOARCH and goarch are needed?
I've attached a patch I used to get it to work. It worked for ppc64le
and ppc64
with 64 and 32 bit.
On 11/03/2015 11:34 AM, Ian Lance Taylor wrote:
> On Tue, Nov 3, 2015 at 7:48 AM, Lynn A. Boger
> <laboger@linux.vnet.ibm.com> wrote:
>> We are seeing failures on all the libgo tests when gccgo is built with the
>> latest trunk
>> on ppc64 (BE) and when running the testsuite for 64 bit. The failures
>> do not occur if run on ppc64 BE with m32 and do not occur on ppc64le.
>>
>> The messages say this:
>>
>> make[3]: Entering directory
>> `/home/boger/gccgo.work/trunk/bld/powerpc64-linux/libgo'
>> gotest: warning: no tests matching Test([^a-z].*)? in _gotest_.o _xtest_.o
>> FAIL: bufio
>> make[3]: *** [bufio/check] Error 1
>> gotest: warning: no tests matching Test([^a-z].*)? in _gotest_.o _xtest_.o
>> FAIL: bytes
>> make[3]: *** [bytes/check] Error 1
>> gotest: warning: no tests matching Test([^a-z].*)? in _gotest_.o _xtest_.o
>> FAIL: errors
> I don't know that I have access to a big-endian PPC GNU/Linux machine any more.
>
> My first guess would be that somehow this case in libgo/testsuite/gotest
>
> text="T"
> case "$GOARCH" in
> ppc64*) text="[TD]" ;;
> esac
>
> is not triggering. Although it checks for ppc64*, I think it's only
> required on PPC64 ABI v1 (big-endian) and is not required for ABI v2
> (little endian).
>
> You could try changing to GOARCH there to goarch to see if it helps,
> although as far as I can see either should work.
>
> Otherwise, cd to the libgo working directory, run "make bufio/check",
> figure out how it is running gotest, and run "bash -xv
> gotest_invocation" and send it here.
>
> Ian
>
>
[-- Attachment #2: gccgo-gotest1.5-fix.diff --]
[-- Type: text/x-patch, Size: 638 bytes --]
Index: libgo/testsuite/gotest
===================================================================
--- libgo/testsuite/gotest (revision 229711)
+++ libgo/testsuite/gotest (working copy)
@@ -35,7 +35,6 @@
pkgpath=
prefix=
dejagnu=no
-GOARCH=""
timeout=240
testname=""
bench=""
@@ -118,15 +117,6 @@
dejagnu=`echo $1 | sed -e 's/^--dejagnu=//'`
shift
;;
- x--goarch)
- GOARCH=$2
- shift
- shift
- ;;
- x--goarch=*)
- GOARCH=`echo $1 | sed -e 's/^--goarch=//'`
- shift
- ;;
x--timeout)
timeout=$2
shift
@@ -496,7 +486,7 @@
{
text="T"
- case "$GOARCH" in
+ case "$goarch" in
ppc64*) text="[TD]" ;;
esac
next prev parent reply other threads:[~2015-11-03 20:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 7:48 Uros Bizjak
2015-11-03 15:07 ` Ian Lance Taylor
2015-11-03 15:48 ` Lynn A. Boger
2015-11-03 17:34 ` Ian Lance Taylor
2015-11-03 20:17 ` Lynn A. Boger [this message]
2015-11-04 1:53 ` Ian Lance Taylor
2015-11-03 22:14 ` Andreas Schwab
-- strict thread matches above, loose matches on Subject: below --
2015-10-31 3:35 Ian Lance Taylor
2015-11-01 8:40 ` Andreas Schwab
2015-11-01 20:33 ` Ian Lance Taylor
2015-11-01 20:52 ` Ian Lance Taylor
2015-11-02 9:38 ` Andreas Schwab
2015-11-02 15:40 ` Lynn A. Boger
2015-11-02 20:23 ` Ian Lance Taylor
2015-11-02 20:59 ` Lynn A. Boger
2015-11-02 19:58 ` Ian Lance Taylor
2015-11-06 13:01 ` Rainer Orth
2015-11-06 19:16 ` Ian Lance Taylor
2015-11-08 17:21 ` Rainer Orth
2015-11-10 21:39 ` Ian Lance Taylor
2015-11-11 11:48 ` Rainer Orth
2015-11-11 13:25 ` Ian Lance Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56391669.3060408@linux.vnet.ibm.com \
--to=laboger@linux.vnet.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gofrontend-dev@googlegroups.com \
--cc=iant@golang.org \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).