From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16893 invoked by alias); 6 Nov 2015 11:38:32 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 16882 invoked by uid 89); 6 Nov 2015 11:38:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (146.101.78.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Nov 2015 11:38:30 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-3-PPi1IeQrTBOoP-EKTTBOrg-1; Fri, 06 Nov 2015 11:38:25 +0000 Received: from [10.2.206.200] ([10.1.2.79]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Fri, 6 Nov 2015 11:38:25 +0000 Message-ID: <563C9130.1040905@arm.com> Date: Fri, 06 Nov 2015 11:38:00 -0000 From: Kyrill Tkachov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Ramana Radhakrishnan , GCC Patches CC: Richard Earnshaw Subject: Re: [PATCH][ARM] Fix checking RTL error in cortex_a9_sched_adjust_cost References: <5632430F.7080402@arm.com> <563380B3.3070007@foss.arm.com> <56339107.2080302@arm.com> <563C90F1.4090304@arm.com> In-Reply-To: <563C90F1.4090304@arm.com> X-MC-Unique: PPi1IeQrTBOoP-EKTTBOrg-1 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00601.txt.bz2 On 06/11/15 11:37, Kyrill Tkachov wrote: > Ping. > https://gcc.gnu.org/ml/gcc-patches/2015-10/msg03170.html My apologies, I meant to ping another patch. Please disregard that. Kyrill > > Thanks, > Kyrill > On 30/10/15 15:47, Kyrill Tkachov wrote: >> >> On 30/10/15 14:37, Ramana Radhakrishnan wrote: >>> >>> On 29/10/15 16:02, Kyrill Tkachov wrote: >>>> Hi all, >>>> >>>> An arm-none-eabi build with RTL checking and --with-cpu=3Dcortex-a9 fa= ils because >>>> cortex_a9_sched_adjust_cost tries to access the SET_DEST of a PARALLEL. >>>> The correct thing to do is to call single_set on dep, which will retur= n a simple SET >>>> that we can take the SET_DEST of or NULL if there's more than one SET. >>>> >>>> This patch does that. >>>> The arm-none-eabi build passes. >>>> Bootstrapped and tested on arm-none-linux-gnueabihf. >>>> >>>> Ok for trunk? >>>> >>>> Thanks, >>>> Kyrill >>>> >>>> 2015-10-29 Kyrylo Tkachov >>>> >>>> * config/arm/arm.c (cortex_a9_sched_adjust_cost): Use reg_set_p to >>>> check for dependencies. >>> Ok - but I think we also need a patch to improve the comment for reg_se= t_p, probably because it started life as internal function but now has wide= r visibility. >> >> Thanks, >> >> Here's a patch for the reg_set_p comment. >> Committing as obvious. >> >> Kyrill >> >>> >>> >>> Thanks, >>> Ramana >>> >> >