From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44718 invoked by alias); 6 Nov 2015 16:18:16 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 44706 invoked by uid 89); 6 Nov 2015 16:18:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 06 Nov 2015 16:18:14 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id B1B64263B; Fri, 6 Nov 2015 16:18:13 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-107.phx2.redhat.com [10.3.113.107]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tA6GID8k031535; Fri, 6 Nov 2015 11:18:13 -0500 Subject: Re: Move #undef DEF_INTERNAL_FN to internal-fn.def To: gcc-patches@gcc.gnu.org, richard.sandiford@arm.com References: <87si4jrvqi.fsf@e105548-lin.cambridge.arm.com> From: Jeff Law Message-ID: <563CD2C5.9050908@redhat.com> Date: Fri, 06 Nov 2015 16:18:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <87si4jrvqi.fsf@e105548-lin.cambridge.arm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00674.txt.bz2 On 11/06/2015 08:30 AM, Richard Sandiford wrote: > In practice the definition of DEF_INTERNAL_FN is never reused after > including internal-fn.def, so we might as well #undef it there. > > This becomes more obvious with a later patch that adds other > DEF_INTERNAL_* directives, such as DEF_INTERNAL_OPTAB_FN. > If the includer doesn't care about the information carried in > these new directives, it can simply leave the macro undefined > and internals.def will provide a definition that forwards to > DEF_INTERNAL_FN. It doesn't make much sense for includers to have > to #undef macros that are defined by internals.def and it seems overly > complicated to get internals.def to undef macros only in the cases > where it provided a definition. Instead I went with the approach of > #undeffing all the DEF_INTERNAL_* macros unconditionally. > > Tested on x86_64-linux-gnu, aarch64-linux-gnu and arm-linux-gnueabi. > OK to install? > > Thanks, > Richard > > > gcc/ > * internal-fn.def: #undef DEF_INTERNAL_FN at the end. > * internal-fn.c: Don't undef it here. > * tree-core.h: Likewise. > OK. jeff