From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14899 invoked by alias); 6 Nov 2015 16:48:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 14880 invoked by uid 89); 6 Nov 2015 16:48:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (207.82.80.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Nov 2015 16:48:08 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-20-6pLwgmlqSH-z_j_2VwK9-A-1; Fri, 06 Nov 2015 16:48:03 +0000 Received: from e105915-lin.cambridge.arm.com ([10.1.2.79]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Fri, 6 Nov 2015 16:48:03 +0000 Subject: Re: [PATCH 1/2][ARM] PR/65956 AAPCS update for alignment attribute To: Jakub Jelinek References: <5596A98A.7080500@arm.com> <5596B421.2030806@foss.arm.com> <2568443.T54aGJxWO1@polaris> <559A5FD1.3040102@arm.com> <559A8F51.80407@foss.arm.com> <559AAF0B.7080405@arm.com> <20151104131351.GE478@tucnak.redhat.com> Cc: Ramana Radhakrishnan , Richard Earnshaw , "gcc-patches@gcc.gnu.org" , fweimer@redhat.com From: Alan Lawrence Message-ID: <563CD9C2.6090603@arm.com> Date: Fri, 06 Nov 2015 16:48:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151104131351.GE478@tucnak.redhat.com> X-MC-Unique: 6pLwgmlqSH-z_j_2VwK9-A-1 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00682.txt.bz2 On 04/11/15 13:13, Jakub Jelinek wrote: > On Mon, Jul 06, 2015 at 05:38:35PM +0100, Alan Lawrence wrote: >> Trying to push these now (svn!), patch 2 is going first. >> >> I realize my second iteration of patch 1/2, dropped the testcases from t= he >> first version. Okay to include those as per >> https://gcc.gnu.org/ml/gcc-patches/2015-07/msg00215.html ? > > FYI, it seems that (most likely) the PR65956 changes on gcc-5-branch > broke libgnat ABI compatibility on arm - it seems that getsubs.adb > from macrosub proglet (and others) are during make check compiled/linked > with system gnatmake/gcc, but the program is run at runtime > against the new libgnat-5.so. If I run it manually against > system libgnat, it works, otherwise it hangs, when Fill_Table from > getsubs.adb calls Get_Line, and indeed it looks like the argument passing > for Get_Line changed and on the callee side it thinks Item (which is 400 > chars string) has random (and in the hanging case negative) number of cha= rs > in it. > > Jakub > Sorry Jakub, can you clarify please, how to reproduce this failure? I've ju= st=20 bootstrapped gcc-5-branch with ada and run the Ada testsuite, which has bui= ld me=20 gcc/ada/rts/libgnat{.a,.so,-5.so}, and I see all tests passing. (Same with= =20 --disable-bootstrap FWIW.) It seems plausible that Ada would be the language affected by the ABI chang= e,=20 obviously it would be somewhat ironic that we broke intercompatibility with= =20 gcc's own libgnat but not against libgnat prior to the change... Thanks, Alan