From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68981 invoked by alias); 6 Nov 2015 20:20:05 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 68970 invoked by uid 89); 6 Nov 2015 20:20:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Nov 2015 20:20:04 +0000 Received: from svr-orw-fem-02x.mgc.mentorg.com ([147.34.96.206] helo=SVR-ORW-FEM-02.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1ZunUP-0001Sj-Db from James_Norris@mentor.com ; Fri, 06 Nov 2015 12:20:01 -0800 Received: from [172.30.80.115] (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.3.224.2; Fri, 6 Nov 2015 12:20:00 -0800 Message-ID: <563D0B6F.6070501@codesourcery.com> Date: Fri, 06 Nov 2015 20:20:00 -0000 From: James Norris User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Jakub Jelinek CC: GCC Patches Subject: Re: OpenACC declare directive updates References: <5637692F.7050306@codesourcery.com> <5639FAC0.2090104@codesourcery.com> <20151106193127.GI5675@tucnak.redhat.com> <563D0345.7010208@codesourcery.com> <20151106194909.GK5675@tucnak.redhat.com> In-Reply-To: <20151106194909.GK5675@tucnak.redhat.com> X-TagToolbar-Keys: D20151106141959644 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2015-11/txt/msg00727.txt.bz2 Jakub, On 11/06/2015 01:49 PM, Jakub Jelinek wrote: > On Fri, Nov 06, 2015 at 01:45:09PM -0600, James Norris wrote: >> Okay, I'll fix this. >> >> After fixing, OK to commit? >> >> Thank you for taking the time for the review. > Well, isn't this patch really dependent on the other one? Yes. Should I combine the patches into a single patch? > > Also, wonder about BLOCK stmt in Fortran, that can give you variables that > don't live through the whole function, but only a portion of it even in > Fortran. Let me scratch my head on that one. > > Jakub Thanks again, Jim