From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119625 invoked by alias); 8 Nov 2015 23:24:03 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 119583 invoked by uid 89); 8 Nov 2015 23:24:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sun, 08 Nov 2015 23:24:01 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 1760B8C1B6; Sun, 8 Nov 2015 23:24:00 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-107.phx2.redhat.com [10.3.113.107]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tA8NNxti027348; Sun, 8 Nov 2015 18:23:59 -0500 Subject: Re: [PATCH 3/7] Update libsanitizer obstack interceptors To: Alan Modra , gcc-patches@gcc.gnu.org References: <20151107080846.GD17177@bubble.grove.modra.org> From: Jeff Law Message-ID: <563FD98F.9010704@redhat.com> Date: Sun, 08 Nov 2015 23:24:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151107080846.GD17177@bubble.grove.modra.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00870.txt.bz2 On 11/07/2015 01:08 AM, Alan Modra wrote: > New obstack uses sensible types, size_t instead of int for length > params. Since libsanitizer does not use prototypes from obstack.h to > call the real functions, it's necessary to update the libsanitizer > function declarations emitted by the INTERCEPTOR macro. > > As per the comment added to configure.ac, it would be nice if we could > update to a more recent autoconf, but what I have should do given the > limited target support for libsanitizer. > > I'll be pushing this one upstream too, when I figure out something > reasonable for cmake. > > * sanitizer_common/sanitizer_common_interceptors.inc: Update size > params for _obstack_begin_1, _obstack_begin, _obstack_newchunk > interceptors. > * configure.ac: Substitute OBSTACK_DEFS. > * asan/Makefile.am: Add OBSTACK_DEFS to DEFS. > * tsan/Makefile.am: Likewise. > * configure: Regenerate. > * Makefile.in: Regenerate. > * asan/Makefile.in: Regenerate. > * interception/Makefile.in: Regenerate. > * libbacktrace/Makefile.in: Regenerate. > * lsan/Makefile.in: Regenerate. > * sanitizer_common/Makefile.in: Regenerate. > * tsan/Makefile.in: Regenerate. > * ubsan/Makefile.in: Regenerate. I'm going to consider this a portability fix, which means it can go in now rather than wait for an upstream merge. OK. But please do continue to coordinate with upstream so that we don't have to carry this as a GCC specific change. jeff