From: Jeff Law <law@redhat.com>
To: Alan Modra <amodra@gmail.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 6/7] Silence obstack.c -Wc++compat warning
Date: Sun, 08 Nov 2015 23:29:00 -0000 [thread overview]
Message-ID: <563FDAC2.8030208@redhat.com> (raw)
In-Reply-To: <20151107081121.GG17177@bubble.grove.modra.org>
On 11/07/2015 01:11 AM, Alan Modra wrote:
> Fixes
> warning: request for implicit conversion from ‘void *’ to ‘struct _obstack_chunk *’ not permitted in C++ [-Wc++-compat]
>
> I moved the assignment to h->chunk to fix an overlong line, then
> decided it would be better after the alloc failure check just to do
> things the same way as in _obstack_newchunk.
>
> * obstack.c (_obstack_newchunk): Silence -Wc++compat warning.
> (_obstack_begin_worker): Likewise. Move assignment to h->chunk
> after alloc failure check.
OK. Please consider feeding this to gnulib since it looks like
something they may want to fix.
jeff
next prev parent reply other threads:[~2015-11-08 23:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-07 8:06 [PATCH 0/7] 64-bit obstack support in libiberty Alan Modra
2015-11-07 8:07 ` [PATCH 1/7] New obstack_next_free is not an lvalue Alan Modra
2015-11-07 11:30 ` Richard Sandiford
2015-11-08 23:19 ` Jeff Law
2015-11-07 8:08 ` [PATCH 2/7] Correct libvtv obstack use Alan Modra
2015-11-08 23:20 ` Jeff Law
2015-11-07 8:08 ` [PATCH 3/7] Update libsanitizer obstack interceptors Alan Modra
2015-11-08 23:24 ` Jeff Law
2015-11-07 8:09 ` [PATCH 4/7] Copy gnulib obstack files Alan Modra
2015-11-08 23:25 ` Jeff Law
2015-11-07 8:10 ` [PATCH 5/7] Modify obstack.[hc] to avoid having to include other gnulib files Alan Modra
2015-11-08 23:27 ` Jeff Law
2015-11-07 8:11 ` [PATCH 6/7] Silence obstack.c -Wc++compat warning Alan Modra
2015-11-08 23:29 ` Jeff Law [this message]
2015-11-07 8:12 ` [PATCH 7/7] Configury changes for obstack optimization Alan Modra
2015-11-08 23:29 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563FDAC2.8030208@redhat.com \
--to=law@redhat.com \
--cc=amodra@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).