From: Bernd Schmidt <bschmidt@redhat.com>
To: Richard Biener <richard.guenther@gmail.com>,
"Bin.Cheng" <amker.cheng@gmail.com>
Cc: Bin Cheng <bin.cheng@arm.com>, GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH PR52272]Be smart when adding iv candidates
Date: Mon, 09 Nov 2015 15:24:00 -0000 [thread overview]
Message-ID: <5640BAAB.3010709@redhat.com> (raw)
In-Reply-To: <35546C22-9163-4D5F-A8D8-76E4F16C3B30@gmail.com>
On 11/08/2015 10:11 AM, Richard Biener wrote:
> On November 8, 2015 3:58:57 AM GMT+01:00, "Bin.Cheng" <amker.cheng@gmail.com> wrote:
>>> +inline bool
>>> +iv_common_cand_hasher::equal (const iv_common_cand *ccand1,
>>> + const iv_common_cand *ccand2)
>>> +{
>>> + return ccand1->hash == ccand2->hash
>>> + && operand_equal_p (ccand1->base, ccand2->base, 0)
>>> + && operand_equal_p (ccand1->step, ccand2->step, 0)
>>> + && TYPE_PRECISION (TREE_TYPE (ccand1->base))
>>> + == TYPE_PRECISION (TREE_TYPE (ccand2->base));
>>>
> Yes. Patch is OK then.
Doesn't follow the formatting rules though in the quoted piece.
Bernd
next prev parent reply other threads:[~2015-11-09 15:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-04 10:18 Bin Cheng
2015-11-06 13:24 ` Richard Biener
2015-11-08 2:59 ` Bin.Cheng
2015-11-08 9:11 ` Richard Biener
2015-11-09 15:24 ` Bernd Schmidt [this message]
2015-11-10 1:26 ` Bin.Cheng
2015-11-10 8:25 ` Bin.Cheng
2015-11-10 10:06 ` Bernd Schmidt
2015-11-10 10:19 ` Bin.Cheng
2015-11-18 15:50 ` Bernd Schmidt
2015-11-20 9:07 ` Bin.Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5640BAAB.3010709@redhat.com \
--to=bschmidt@redhat.com \
--cc=amker.cheng@gmail.com \
--cc=bin.cheng@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).