From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-413266-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 127070 invoked by alias); 9 Nov 2015 15:24:33 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 123269 invoked by uid 89); 9 Nov 2015 15:24:32 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 09 Nov 2015 15:24:31 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (Postfix) with ESMTPS id 37E78C19CFCA;	Mon,  9 Nov 2015 15:24:30 +0000 (UTC)
Received: from localhost.localdomain (vpn1-6-175.ams2.redhat.com [10.36.6.175])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tA9FOR8q012133;	Mon, 9 Nov 2015 10:24:29 -0500
Subject: Re: [PATCH PR52272]Be smart when adding iv candidates
To: Richard Biener <richard.guenther@gmail.com>,        "Bin.Cheng" <amker.cheng@gmail.com>
References: <000901d116ea$19388d70$4ba9a850$@arm.com> <CAFiYyc1UTfA1pHQ+QSRBmO6SF0Xfu9Gs5kmKurDWryowY9=RTg@mail.gmail.com> <CAHFci291ZFYgYAKLmm3WecnBzRoJNiKgnbYg3K2XYCGyBWGWQQ@mail.gmail.com> <35546C22-9163-4D5F-A8D8-76E4F16C3B30@gmail.com>
Cc: Bin Cheng <bin.cheng@arm.com>, GCC Patches <gcc-patches@gcc.gnu.org>
From: Bernd Schmidt <bschmidt@redhat.com>
Message-ID: <5640BAAB.3010709@redhat.com>
Date: Mon, 09 Nov 2015 15:24:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <35546C22-9163-4D5F-A8D8-76E4F16C3B30@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2015-11/txt/msg00982.txt.bz2

On 11/08/2015 10:11 AM, Richard Biener wrote:
> On November 8, 2015 3:58:57 AM GMT+01:00, "Bin.Cheng" <amker.cheng@gmail.com> wrote:
>>> +inline bool
>>> +iv_common_cand_hasher::equal (const iv_common_cand *ccand1,
>>> +                          const iv_common_cand *ccand2)
>>> +{
>>> +  return ccand1->hash == ccand2->hash
>>> +        && operand_equal_p (ccand1->base, ccand2->base, 0)
>>> +        && operand_equal_p (ccand1->step, ccand2->step, 0)
>>> +        && TYPE_PRECISION (TREE_TYPE (ccand1->base))
>>> +             == TYPE_PRECISION (TREE_TYPE (ccand2->base));
>>>
> Yes.  Patch is OK then.

Doesn't follow the formatting rules though in the quoted piece.


Bernd