From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89049 invoked by alias); 9 Nov 2015 18:34:22 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 89039 invoked by uid 89); 9 Nov 2015 18:34:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.5 required=5.0 tests=AWL,BAYES_50,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 09 Nov 2015 18:34:20 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 78A213C20D; Mon, 9 Nov 2015 18:34:19 +0000 (UTC) Received: from localhost.localdomain (vpn1-6-175.ams2.redhat.com [10.36.6.175]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tA9IYIa1032015; Mon, 9 Nov 2015 13:34:18 -0500 Subject: Re: [PATCH 05/12] always define VMS_DEBUGGING_INFO To: tbsaunde+gcc@tbsaunde.org, gcc-patches@gcc.gnu.org References: <1447087669-14039-1-git-send-email-tbsaunde+gcc@tbsaunde.org> <1447087669-14039-6-git-send-email-tbsaunde+gcc@tbsaunde.org> From: Bernd Schmidt Message-ID: <5640E729.9010605@redhat.com> Date: Mon, 09 Nov 2015 18:34:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1447087669-14039-6-git-send-email-tbsaunde+gcc@tbsaunde.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg01057.txt.bz2 In general I think the _DEBUGGING_INFO patches are going to be OK, modulo Jeff's comment about stage 1. I think they shouldn't have been split - it causes numerous unnecessary extra changes, and the intermediate stages look very inconsistent. > -#ifdef VMS_DEBUGGING_INFO > - else if (write_symbols == VMS_DEBUG || write_symbols == VMS_AND_DWARF2_DEBUG) > + else if (VMS_DEBUGGING_INFO > + && (write_symbols == VMS_DEBUG > + || write_symbols == VMS_AND_DWARF2_DEBUG)) > debug_hooks = &vmsdbg_debug_hooks; > -#endif > #ifdef DWARF2_LINENO_DEBUGGING_INFO > else if (write_symbols == DWARF2_DEBUG) > debug_hooks = &dwarf2_lineno_debug_hooks; > diff --git a/gcc/vmsdbgout.c b/gcc/vmsdbgout.c > index d41d4b2..6dd6878 100644 > --- a/gcc/vmsdbgout.c > +++ b/gcc/vmsdbgout.c > @@ -24,7 +24,7 @@ along with GCC; see the file COPYING3. If not see > #include "coretypes.h" > #include "tm.h" > > -#ifdef VMS_DEBUGGING_INFO > +#if VMS_DEBUGGING_INFO > #include "alias.h" > #include "tree.h" > #include "varasm.h" This seems to reference vmsdbg_debug_hooks unconditionally, but as far as I can tell the definition is still guarded by an #if? Does this compile? Bernd