From: Bernd Schmidt <bschmidt@redhat.com>
To: Jeff Law <law@redhat.com>,
tbsaunde+gcc@tbsaunde.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 10/12] always define EH_RETURN_HANDLER_RTX
Date: Mon, 09 Nov 2015 18:50:00 -0000 [thread overview]
Message-ID: <5640EAFD.8080806@redhat.com> (raw)
In-Reply-To: <5640E90B.8060808@redhat.com>
On 11/09/2015 07:42 PM, Jeff Law wrote:
> On 11/09/2015 11:27 AM, Bernd Schmidt wrote:
>> On 11/09/2015 05:47 PM, tbsaunde+gcc@tbsaunde.org wrote:
>>> From: Trevor Saunders <tbsaunde+gcc@tbsaunde.org>
>>>
>>> gcc/ChangeLog:
>>>
>>> 2015-11-09 Trevor Saunders <tbsaunde+gcc@tbsaunde.org>
>>>
>>> * defaults.h (EH_RETURN_HANDLER_RTX): New default definition.
>>> * df-scan.c (df_get_exit_block_use_set): Adjust.
>>> * except.c (expand_eh_return): Likewise.
>>
>> As I said for a previous patch series, if we go to the trouble of fixing
>> up stuff like this, we might as well do it properly and turn things like
>> this into a target hook.
> I agree that pushing hookization further is good as well. I still think
> the patch in and of itself is a step forward, even if it doesn't hookize
> EH_RETURN_HANDLER_RTX.
Well, I was hoping that, by pointing out the issue for the last patch
set, the next set of patches would get things right. We really shouldn't
make sideways steps when there's a simple way to go forward.
Bernd
next prev parent reply other threads:[~2015-11-09 18:50 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-09 16:45 [PATCH 00/12] misc conditional compilation work tbsaunde+gcc
2015-11-09 16:45 ` [PATCH 08/12] always define DWARF2_LINENO_DEBUGGING_INFO tbsaunde+gcc
2015-11-09 16:45 ` [PATCH 10/12] always define EH_RETURN_HANDLER_RTX tbsaunde+gcc
2015-11-09 17:42 ` David Malcolm
2015-11-09 18:27 ` Bernd Schmidt
2015-11-09 18:42 ` Jeff Law
2015-11-09 18:50 ` Bernd Schmidt [this message]
2015-11-09 18:52 ` Trevor Saunders
2015-11-09 19:38 ` Bernd Schmidt
2015-11-09 19:46 ` Jeff Law
2015-11-09 21:07 ` Mike Stump
2015-11-09 21:30 ` Trevor Saunders
2015-11-09 22:07 ` Jeff Law
2015-11-09 22:53 ` Trevor Saunders
2015-11-10 22:02 ` Bernd Schmidt
2015-11-11 0:43 ` Trevor Saunders
2015-11-10 1:32 ` Joseph Myers
2015-11-09 16:46 ` [PATCH 02/12] remove EXTENDED_SDB_BASIC_TYPES tbsaunde+gcc
2015-11-09 18:49 ` Bernd Schmidt
2015-11-09 16:46 ` [PATCH 09/12] always define TARGET_PECOFF tbsaunde+gcc
2015-11-09 16:46 ` [PATCH 06/12] always define DWARF2_DEBUGGING_INFO tbsaunde+gcc
2015-11-09 16:46 ` [PATCH 05/12] always define VMS_DEBUGGING_INFO tbsaunde+gcc
2015-11-09 18:34 ` Bernd Schmidt
2015-11-09 18:44 ` Jeff Law
2015-11-09 19:29 ` Trevor Saunders
2015-11-09 19:37 ` Bernd Schmidt
2015-11-09 21:56 ` Trevor Saunders
2015-11-09 16:46 ` [PATCH 03/12] remove conditional compilation of sdb debug info tbsaunde+gcc
2015-11-09 16:46 ` [PATCH 01/12] reduce conditional compilation for HARD_FRAME_POINTER_IS_ARG_POINTER tbsaunde+gcc
2015-11-09 19:01 ` Bernd Schmidt
2015-11-09 20:58 ` Trevor Saunders
2015-11-09 21:09 ` Bernd Schmidt
2015-11-09 16:46 ` [PATCH 11/12] always define HAVE_AS_LEB128 tbsaunde+gcc
2015-11-09 18:42 ` Bernd Schmidt
2015-11-09 21:04 ` Trevor Saunders
2015-11-09 16:46 ` [PATCH 04/12] always define XCOFF_DEBUGGING_INFO tbsaunde+gcc
2015-11-09 16:46 ` [PATCH 07/12] always define DBX_DEBUGGING_INFO tbsaunde+gcc
2015-11-09 16:46 ` [PATCH 12/12] always define ENABLE_OFFLOADING tbsaunde+gcc
2015-11-09 18:41 ` Bernd Schmidt
2015-11-23 16:53 ` Ilya Verbin
2015-11-24 12:51 ` Bernd Schmidt
2015-11-24 18:14 ` Thomas Schwinge
2015-11-09 17:57 ` [PATCH 00/12] misc conditional compilation work Jeff Law
2015-11-09 19:01 ` Trevor Saunders
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5640EAFD.8080806@redhat.com \
--to=bschmidt@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
--cc=tbsaunde+gcc@tbsaunde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).