On 11/09/2015 08:00 AM, Michael Matz wrote:
> Hi,
>
> On Mon, 9 Nov 2015, Jeff Law wrote:
>
> +verify_ssaname_freelists (struct function *fun)
> +{
> +  /* Do nothing if we are in RTL format.  */
> +  basic_block bb;
> +  FOR_EACH_BB_FN (bb, fun)
> +    {
> +      if (bb->flags & BB_RTL)
> +       return;
> +    }
>
> gimple_in_ssa_p (fun);
Agreed & fixed.

>
> +      /* Then note the operands of each statement.  */
> +      for (gimple_stmt_iterator gsi = gsi_start_bb (bb);
> +          !gsi_end_p (gsi);
> +          gsi_next (&gsi))
> +       {
> +         ssa_op_iter iter;
> +         gimple *stmt = gsi_stmt (gsi);
> +         FOR_EACH_SSA_TREE_OPERAND (t, stmt, iter, SSA_OP_ALL_OPERANDS)
> +           if (TREE_CODE (t) == SSA_NAME)
> +             bitmap_set_bit (names_in_il, SSA_NAME_VERSION (t));
> +       }
>
> t will always be an SSA_NAME here.
Likewise.  I think that test was in there from a time when I'd run the 
verifier at a different point in the pipeline and things weren't 
necessarily consistent.  I'll simplify in the obvious way.

I put bootstrapped x86_64-linux-gnu with the verifier enabled. 
Installed on the trunk.

Thanks for catching these.


Jeff