From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9686 invoked by alias); 10 Nov 2015 10:06:12 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 9674 invoked by uid 89); 10 Nov 2015 10:06:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 10 Nov 2015 10:06:11 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id E62B3C0B1B50; Tue, 10 Nov 2015 10:06:09 +0000 (UTC) Received: from localhost.localdomain (vpn1-6-250.ams2.redhat.com [10.36.6.250]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tAAA68Fl001019; Tue, 10 Nov 2015 05:06:08 -0500 Subject: Re: [PATCH PR52272]Be smart when adding iv candidates To: "Bin.Cheng" References: <000901d116ea$19388d70$4ba9a850$@arm.com> <35546C22-9163-4D5F-A8D8-76E4F16C3B30@gmail.com> <5640BAAB.3010709@redhat.com> Cc: Richard Biener , Bin Cheng , GCC Patches From: Bernd Schmidt Message-ID: <5641C190.60209@redhat.com> Date: Tue, 10 Nov 2015 10:06:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg01166.txt.bz2 On 11/10/2015 09:25 AM, Bin.Cheng wrote: >> Thanks for reviewing. I haven't committed it yet, could you please >> point out which quoted piece is so that I can update patch? Sorry, I thought it was pretty obvious... > +{ > + return ccand1->hash == ccand2->hash > + && operand_equal_p (ccand1->base, ccand2->base, 0) > + && operand_equal_p (ccand1->step, ccand2->step, 0) > + && TYPE_PRECISION (TREE_TYPE (ccand1->base)) > + == TYPE_PRECISION (TREE_TYPE (ccand2->base)); > +} > + Multi-line expressions should be wrapped in parentheses so that emacs/indent can format them automatically. Two sets of parens are needed for this. Operators should then line up appropriately. Bernd