public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Bernd Schmidt <bschmidt@redhat.com>
To: David Malcolm <dmalcolm@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 01/02] PR/62314: add ability to add fixit-hints
Date: Tue, 10 Nov 2015 16:26:00 -0000	[thread overview]
Message-ID: <56421AAA.7030503@redhat.com> (raw)
In-Reply-To: <1447173325-48683-1-git-send-email-dmalcolm@redhat.com>

On 11/10/2015 05:35 PM, David Malcolm wrote:
> +  /* Nasty workaround to convince the linker to add
> +      rich_location::add_fixit_insert
> +      rich_location::add_fixit_remove
> +      rich_location::add_fixit_replace
> +     to cc1 for use by diagnostic_plugin_test_show_locus,
> +     before anything in cc1 is using them.
> +
> +     This conditional should never hold, but hopefully the compiler can't
> +     figure that out.  */

Does attribute((used)) help with this problem?


Bernd

  parent reply	other threads:[~2015-11-10 16:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-10 16:17 David Malcolm
2015-11-10 16:17 ` [PATCH 02/02] C FE: add fix-it hint for . vs -> David Malcolm
2015-11-10 17:55   ` Joseph Myers
2015-11-12 19:46     ` David Malcolm
2015-11-12 20:58       ` Joseph Myers
2015-11-10 16:26 ` Bernd Schmidt [this message]
2015-11-10 17:03   ` [PATCH 01/02] PR/62314: add ability to add fixit-hints David Malcolm
2015-11-18 21:57 ` Jeff Law
2015-11-18 22:25   ` David Malcolm
2015-11-24 20:04     ` Jeff Law
2015-11-25 11:12       ` Bernd Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56421AAA.7030503@redhat.com \
    --to=bschmidt@redhat.com \
    --cc=dmalcolm@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).