From: Kyrill Tkachov <kyrylo.tkachov@arm.com>
To: Charles Baylis <charles.baylis@linaro.org>
Cc: Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>,
Alan Lawrence <alan.lawrence@arm.com>,
Richard Earnshaw <rearnsha@arm.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 4b/4] [ARM] PR63870 Remove error for invalid lane numbers
Date: Wed, 11 Nov 2015 12:10:00 -0000 [thread overview]
Message-ID: <56433028.6070809@arm.com> (raw)
In-Reply-To: <CADnVucD=LvKcUQcB0_zTPOsizqib151AF-k1M17m0yR3=DdOeA@mail.gmail.com>
On 11/11/15 12:08, Charles Baylis wrote:
> On 11 November 2015 at 11:22, Kyrill Tkachov <kyrylo.tkachov@arm.com> wrote:
>> Hi Charles,
>>
>> On 08/11/15 00:26, charles.baylis@linaro.org wrote:
>>> From: Charles Baylis <charles.baylis@linaro.org>
>>>
>>> <DATE> Charles Baylis <charles.baylis@linaro.org>
>>>
>>> * config/arm/neon.md (neon_vld1_lane<mode>): Remove error for
>>> invalid
>>> lane number.
>>> (neon_vst1_lane<mode>): Likewise.
>>> (neon_vld2_lane<mode>): Likewise.
>>> (neon_vst2_lane<mode>): Likewise.
>>> (neon_vld3_lane<mode>): Likewise.
>>> (neon_vst3_lane<mode>): Likewise.
>>> (neon_vld4_lane<mode>): Likewise.
>>> (neon_vst4_lane<mode>): Likewise.
>>>
>> In this pattern the 'max' variable is now unused, causing a bootstrap
>> -Werror failure on arm.
>> I'll test a patch to fix it unless you beat me to it...
> Thanks for catching this.
>
> I have a patch, and have started a bootstrap. Unless you have
> objections, I'll apply as obvious once the bootstrap is complete later
> this afternoon.
Yes, that's the exact patch I'm testing as well.
I'll let you finish the bootstrap and commit it.
Thanks,
Kyrill
>
> gcc/ChangeLog:
>
> 2015-11-11 Charles Baylis <charles.baylis@linaro.org>
>
> * config/arm/neon.md: (neon_vld2_lane<mode>): Remove unused max
> variable.
> (neon_vst2_lane<mode>): Likewise.
> (neon_vld3_lane<mode>): Likewise.
> (neon_vst3_lane<mode>): Likewise.
> (neon_vld4_lane<mode>): Likewise.
> (neon_vst4_lane<mode>): Likewise.
next prev parent reply other threads:[~2015-11-11 12:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-08 0:27 [PATCH v3 0/4] [ARM] PR63870 vldN_lane/vstN_lane error messages charles.baylis
2015-11-08 0:27 ` [PATCH 4a/4] [ARM] PR63870 Use internal_error() for invalid lane numbers charles.baylis
2015-11-08 0:27 ` [PATCH 4b/4] [ARM] PR63870 Remove error " charles.baylis
2015-11-09 13:35 ` Ramana Radhakrishnan
2015-11-12 13:13 ` Charles Baylis
2015-11-11 11:23 ` Kyrill Tkachov
2015-11-11 12:08 ` Charles Baylis
2015-11-11 12:10 ` Kyrill Tkachov [this message]
2015-11-12 2:54 ` Charles Baylis
2015-11-08 0:27 ` [PATCH 1/4] [ARM] PR63870 Add qualifiers for NEON builtins charles.baylis
2015-11-09 9:03 ` Ramana Radhakrishnan
2015-11-12 13:12 ` Charles Baylis
2015-11-08 0:27 ` [PATCH 2/4] [ARM] PR63870 Mark lane indices of vldN/vstN with appropriate qualifier charles.baylis
2015-11-09 9:14 ` Ramana Radhakrishnan
2015-11-08 0:27 ` [PATCH 3/4] [ARM] PR63870 Add test cases charles.baylis
2015-11-09 9:19 ` Ramana Radhakrishnan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56433028.6070809@arm.com \
--to=kyrylo.tkachov@arm.com \
--cc=Ramana.Radhakrishnan@arm.com \
--cc=alan.lawrence@arm.com \
--cc=charles.baylis@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=rearnsha@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).