From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-413655-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 107465 invoked by alias); 11 Nov 2015 13:44:44 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 107455 invoked by uid 89); 11 Nov 2015 13:44:42 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-yk0-f174.google.com
Received: from mail-yk0-f174.google.com (HELO mail-yk0-f174.google.com) (209.85.160.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 11 Nov 2015 13:44:38 +0000
Received: by ykdv3 with SMTP id v3so48543572ykd.0        for <gcc-patches@gcc.gnu.org>; Wed, 11 Nov 2015 05:44:36 -0800 (PST)
X-Received: by 10.129.104.215 with SMTP id d206mr10383195ywc.224.1447249476289;        Wed, 11 Nov 2015 05:44:36 -0800 (PST)
Received: from ?IPv6:2601:181:c000:c497:a2a8:cdff:fe3e:b48? ([2601:181:c000:c497:a2a8:cdff:fe3e:b48])        by smtp.googlemail.com with ESMTPSA id v127sm10545317ywd.53.2015.11.11.05.44.35        (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);        Wed, 11 Nov 2015 05:44:35 -0800 (PST)
Subject: Re: OpenACC Firstprivate
To: Jakub Jelinek <jakub@redhat.com>
References: <563E01A4.20607@acm.org> <20151109134619.GQ5675@tucnak.redhat.com> <5640A6B3.3030409@acm.org> <20151109141034.GS5675@tucnak.redhat.com> <5640B1B4.2070701@acm.org> <5641FB67.9010409@acm.org> <20151111080459.GD5675@tucnak.redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, Cesar Philippidis <cesar_philippidis@mentor.com>
From: Nathan Sidwell <nathan@acm.org>
Message-ID: <56434643.6010009@acm.org>
Date: Wed, 11 Nov 2015 13:44:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <20151111080459.GD5675@tucnak.redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2015-11/txt/msg01371.txt.bz2

On 11/11/15 03:04, Jakub Jelinek wrote:
> On Tue, Nov 10, 2015 at 09:12:55AM -0500, Nathan Sidwell wrote:
>> +		    /* Create a local object to hold the instance
>> +		       value.  */
>> +		    tree inst = create_tmp_var
>> +		      (TREE_TYPE (TREE_TYPE (new_var)),
>> +		       IDENTIFIER_POINTER (DECL_NAME (new_var)));
>
> Can you please rewrite this as:
> 		    tree type = TREE_TYPE (TREE_TYPE (new_var));
> 		    tree n = DECL_NAME (new_var);
> 		    tree inst = create_tmp_var (type, IDENTIFIER_POINTER (n));
> or so (perhaps
> 		    const char *name
> 		      = IDENTIFIER_POINTER (DECL_NAME (new_var));
> instead but then it takes one more line)?
> I really don't like line breaks before opening ( unless really
> necessary.

Oh, yeah you mentioned that before :)

>
> Otherwise LGTM.

thanks.

nathan