From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88644 invoked by alias); 11 Nov 2015 13:59:24 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 88613 invoked by uid 89); 11 Nov 2015 13:59:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-yk0-f177.google.com Received: from mail-yk0-f177.google.com (HELO mail-yk0-f177.google.com) (209.85.160.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 11 Nov 2015 13:59:21 +0000 Received: by ykfs79 with SMTP id s79so49216719ykf.1 for ; Wed, 11 Nov 2015 05:59:18 -0800 (PST) X-Received: by 10.129.89.132 with SMTP id n126mr9423501ywb.109.1447250358809; Wed, 11 Nov 2015 05:59:18 -0800 (PST) Received: from ?IPv6:2601:181:c000:c497:a2a8:cdff:fe3e:b48? ([2601:181:c000:c497:a2a8:cdff:fe3e:b48]) by smtp.googlemail.com with ESMTPSA id u189sm10658543ywd.21.2015.11.11.05.59.17 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Nov 2015 05:59:18 -0800 (PST) Subject: Re: [ptx] partitioning optimization To: Bernd Schmidt , GCC Patches References: <564270D6.6090303@acm.org> <56432F50.6000208@redhat.com> From: Nathan Sidwell Message-ID: <564349B5.5050202@acm.org> Date: Wed, 11 Nov 2015 13:59:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <56432F50.6000208@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2015-11/txt/msg01373.txt.bz2 On 11/11/15 07:06, Bernd Schmidt wrote: > On 11/10/2015 11:33 PM, Nathan Sidwell wrote: >> I've committed this patch to trunk. It implements a partitioning >> optimization for a loop partitioned over both vector and worker axes. >> We can elide the inner vector partitioning state propagation, if there >> are no intervening instructions in the worker-partitioned outer loop >> other than the forking and joining. We simply execute the worker >> propagation on all vectors. > > Patch LGTM, although I wonder if you really need the extra option rather than > just optimize. The reason I added the option was to be able to turn it off independent of the other optimizations, (in cases of debugging) >> I've been unable to introduce a testcase for this. The difficulty is we >> want to check an rtl dump from the acceleration compiler, and there >> doesn't appear to be existing machinery for that in the testsuite. >> Perhaps something to be added later? > > What's the difficulty exactly? Getting a dump should be possible with > -foffload=-fdump-whatever, does the testsuite have a problem finding the right > filename? That's not the problem. How to conditionally enable the test is the difficulty. I suspect porting something concerning accel_compiler from the libgomp testsuite is needed? nathan