From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B3065384AB40 for ; Tue, 28 May 2024 19:52:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B3065384AB40 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B3065384AB40 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716925957; cv=none; b=V5yRFsq9qVybPwMomr6HxMnvrFD7baVqovEzuOgHRg0VD0pOuaRLQYeMVvswYcx8t6pvq+3DW3IcYCRVCzfgvPV+DKV6/aR5deZq6vUt/lUs+7n5ypHGILjyOf6QCLNS/esSxbPf5DDmBYJfJQdjINWN4LNbsfD6lE6jJ2no1Go= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716925957; c=relaxed/simple; bh=xUB0rp0pJ9PGGAXCKmFeIVFvSCc7WQ6mYQy3szyOJK8=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=vcgJGcqogCKIkvWOacTEltYN8jSWN4VtXwJeCO3lqHJy2XY8SoZKLTRdhlyzgKoKuppfmv9ygyZgdPmwulJP4obiepGYYssUpUmyLEY8pehw0QYv5mgVEjjx2nGioFQelQlsy/Q3XoOTTTAOBFt+wPq0/XwxuHOaYXK5oPPyEVQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1716925955; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xUB0rp0pJ9PGGAXCKmFeIVFvSCc7WQ6mYQy3szyOJK8=; b=ZQIYQwzjNoHdoDqIES++ExPTJVq35Ce9wIy3ARIya99cm9iWviDabx3iRksw/k8khmLKCq +IPhXQBJCmZgHXwY8acmbu/QGAC7uIsyIV4OB1kzRrxkxqMabd3uQSGgq6IjwBiCOUPail XQWbTmTKLGMfsKWpoDaYC/g2Ixa5ksw= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-30-mP4Sb3xRPWSx6MHKCUIUog-1; Tue, 28 May 2024 15:52:33 -0400 X-MC-Unique: mP4Sb3xRPWSx6MHKCUIUog-1 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-43fb2835731so11818151cf.1 for ; Tue, 28 May 2024 12:52:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716925953; x=1717530753; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=xUB0rp0pJ9PGGAXCKmFeIVFvSCc7WQ6mYQy3szyOJK8=; b=de/e5rUyDya3KRIsD4Jfk95mmSuWryhuR/Ef0M6mQSsuo2MBcS7lNcfZc+owbiQ3f4 cxMw7TskAE5HeBmNODud1auc1sfYElQ44HjuYjz4CFwSv5VO+9HgbFkMyv9wYBzq4cTu jLQhENFVenHa/kyiwHLRFfMot/PsJb7uNTPpNNFN/BVdJhHJG4YTn2GvGTaTzMIHRsxN p+zVRhgycq56PYlUGYeK1DQpVyLowndXaR0Hon41oblCxkfoEO97JxiQZZfeLSqTCuGq xxSXz/A3/TY8vzKnxYQa2dj1X7y63QMd9P72hr5XVKK7sZ34x39NLkUqem3mqlXCg6+a 0fdw== X-Gm-Message-State: AOJu0YxrMKhCd2uNyYuwEuxPgI6qQ+kyHeJrNPGg+DpEifP166eUGvfw cuVP858x1JID7tXingYYT9iXlmLw1xl3qjOXWIvrTC1gnKB5rjNg2rNPLmKmig+zteQ+dWQ8TTw LXsX779LVOwK3ZNb+V6qXQto1fVMFmfPA3lkN8xYWtnBdTIwfxgjptVU= X-Received: by 2002:ac8:5ad3:0:b0:437:bf2f:9bcb with SMTP id d75a77b69052e-43fb0e8f0aamr138539621cf.22.1716925953065; Tue, 28 May 2024 12:52:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGXg76Rt513AWl9gs/LrauPopHrigT+Wbe4MF3j48NwtP0SVIQ1poamp6v9Hi0Xd0Gb5PiR4Q== X-Received: by 2002:ac8:5ad3:0:b0:437:bf2f:9bcb with SMTP id d75a77b69052e-43fb0e8f0aamr138539461cf.22.1716925952607; Tue, 28 May 2024 12:52:32 -0700 (PDT) Received: from t14s.localdomain (c-76-28-97-5.hsd1.ma.comcast.net. [76.28.97.5]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-43fb17dc0b2sm45497141cf.32.2024.05.28.12.52.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 May 2024 12:52:32 -0700 (PDT) Message-ID: <564359ff9ecabebd67724df78f71e07a398c3657.camel@redhat.com> Subject: Re: [PATCH] regenerate-opt-urls.py: fix transposed values for "vax" and "v850" From: David Malcolm To: Mark Wielaard , "Maciej W . Rozycki" , Abe Skolnik , Nick Clifton Cc: gcc-patches@gcc.gnu.org Date: Tue, 28 May 2024 15:52:31 -0400 In-Reply-To: <20240528154125.3770757-1-dmalcolm@redhat.com> References: <20240528154125.3770757-1-dmalcolm@redhat.com> User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 2024-05-28 at 11:41 -0400, David Malcolm wrote: > > On Tue, 2024-05-28 at 15:03 +0200, Mark Wielaard wrote: > > Hi Maciej (Hi David, added to CC), >=20 > > On Mon, 2024-05-27 at 05:19 +0100, Maciej W. Rozycki wrote: > > > =C2=A0As reported in PR target/79646 and fixed by a change proposed b= y > > > Abe we=20 > > > have a couple of issues with the descriptions of the VAX > > > floating-point=20 > > > format options in the option definition file.=C2=A0 Additionally most > > > of > > > these=20 > > > options are not documented in the manual. > > >=20 > > > =C2=A0This mini patch series addresses these issues, including Abe's > > > change,=20 > > > slightly updated, and my new change.=C2=A0 See individual change > > > descriptions=20 > > > for details. > > >=20 > > > =C2=A0Verified by inspecting output produced by `vax-netbsdelf-gcc -v > > > --help'=20 > > > and by eyeballing `gcc.info' and `gcc.pdf' files produced.=20 > > > Committed. > >=20 > > This broke the gcc-autoregen checker because the > > gcc/config/vax/vax.opt.urls file wasn't regenerated: > > https://builder.sourceware.org/buildbot/#/builders/269/builds/5347 > >=20 > > Producing the following diff: > >=20 > > diff --git a/gcc/config/vax/vax.opt.urls > > b/gcc/config/vax/vax.opt.urls > > index c6b1c418b61..ca78b31dd4c 100644 > > --- a/gcc/config/vax/vax.opt.urls > > +++ b/gcc/config/vax/vax.opt.urls > > @@ -1,7 +1,13 @@ > > =C2=A0; Autogenerated by regenerate-opt-urls.py from > > gcc/config/vax/vax.opt and generated HTML > > =C2=A0 > > +; skipping UrlSuffix for 'md' due to finding no URLs > > + > > +; skipping UrlSuffix for 'md-float' due to finding no URLs > > + > > =C2=A0; skipping UrlSuffix for 'mg' due to finding no URLs > > =C2=A0 > > +; skipping UrlSuffix for 'mg-float' due to finding no URLs > > + > > =C2=A0; skipping UrlSuffix for 'mgnu' due to finding no URLs > > =C2=A0 > > =C2=A0; skipping UrlSuffix for 'munix' due to finding no URLs > >=20 > > I am not completely clear on why though. Since it seems you > > actually > > did add documentation for exactly these options. > >=20 > > David, should the above diff just be checked in, or do we need to > > investigate why the URLs weren't found? >=20 > [adding Nick, re the v850 target] >=20 > I found the problem - I messed up when I was populating > TARGET_SPECIFIC_PAGES in regenerate-opt-urls.py, accidentally > transposing the entries for v850 and vax by writing: >=20 > =C2=A0=C2=A0=C2=A0 'gcc/V850-Options.html' : 'gcc/config/vax/', > =C2=A0=C2=A0=C2=A0 'gcc/VAX-Options.html' : 'gcc/config/v850/', >=20 > leading to both gcc/config/v850/v850.opt.urls and > gcc/config/vax/vax.opt.urls being full of such comments. >=20 > Sorry. >=20 > Fixing that leads to the files for both targets being populated with > correct-looking URL entries. >=20 > I'll push this to trunk (and backport to gcc 14) after suitable > testing. I've pushed this to gcc trunk as r15-872-g7cc529fe514cc6 (having bootstrapped and lightly tested it on x86_64-pc-linux-gnu) Dave