public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* tm_p.h for bb-reorder.c?
@ 2015-11-12 19:48 Mike Stump
  2015-11-12 19:56 ` Jeff Law
  0 siblings, 1 reply; 2+ messages in thread
From: Mike Stump @ 2015-11-12 19:48 UTC (permalink / raw)
  To: GCC Patches

My port needs the below patch.  I think this was reduced by someone on a port that didn’t use some features (TARGET_SHORT_BRANCH_CHEAPER) of tm.h. 

So, the question is, is this the preferred way to do this?  I don’t want to hookize TARGET_SHORT_BRANCH_CHEAPER, which is the other fix.

If yes, Ok?

diff --git a/gcc/bb-reorder.c b/gcc/bb-reorder.c
index 3dcb82a..7a2b351 100644
--- a/gcc/bb-reorder.c
+++ b/gcc/bb-reorder.c
@@ -114,6 +114,7 @@
 #include "bb-reorder.h"
 #include "except.h"
 #include "fibonacci_heap.h"
+#include "tm_p.h"
 
 /* The number of rounds.  In most cases there will only be 4 rounds, but
    when partitioning hot and cold basic blocks into separate sections of

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: tm_p.h for bb-reorder.c?
  2015-11-12 19:48 tm_p.h for bb-reorder.c? Mike Stump
@ 2015-11-12 19:56 ` Jeff Law
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Law @ 2015-11-12 19:56 UTC (permalink / raw)
  To: Mike Stump, GCC Patches

On 11/12/2015 12:46 PM, Mike Stump wrote:
> My port needs the below patch.  I think this was reduced by someone on a port that didnÂ’t use some features (TARGET_SHORT_BRANCH_CHEAPER) of tm.h.
>
> So, the question is, is this the preferred way to do this?  I donÂ’t want to hookize TARGET_SHORT_BRANCH_CHEAPER, which is the other fix.
>
> If yes, Ok?
I'd prefer not.  We will likely run the reducers regularly and each time 
someone is going to look at this and have to remember that it's dealing 
with a need that is specific to an out-of-tree port.

I'd recommend hookizing.


Jeff


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-11-12 19:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-12 19:48 tm_p.h for bb-reorder.c? Mike Stump
2015-11-12 19:56 ` Jeff Law

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).