From: Tom de Vries <Tom_deVries@mentor.com>
To: Thomas Schwinge <thomas@codesourcery.com>
Cc: "gcc-patches@gnu.org" <gcc-patches@gnu.org>
Subject: Re: [committed] gen-pass-instances.awk: Simplify match regexp in handle_line
Date: Fri, 13 Nov 2015 10:29:00 -0000 [thread overview]
Message-ID: <5645BB5C.6030601@mentor.com> (raw)
In-Reply-To: <87d1vetgwf.fsf@kepler.schwinge.homeip.net>
On 13/11/15 09:58, Thomas Schwinge wrote:
> Hi Tom!
>
> As I happend to see this, and have a number of older build trees around:
>
> On Thu, 12 Nov 2015 11:09:04 +0100, Tom de Vries <Tom_deVries@mentor.com> wrote:
>> this patch [and another dozen of such patches before] simplifies [...] in
>> gen-pass-instances.awk.
>>
>> Committed to trunk as trivial.
>
> Supposing this was the intention, just to confirm: the generated
> gcc/pass-instances.def files that I looked at did not change after your
> recent gcc/gen-pass-instances.awk changes.
>
Hi Thomas,
thanks for double-checking and letting me know.
Indeed, that was the intention. I intend to change
gen-pass-instances.awk for PR68247 - "Remove pass_first_instance", and
I'm trying to achieve a minimal diff that contains functional changes,
by splitting of trivial improvements that do not contain functional changes.
And agreed, comparing the gcc/pass-instances.def buildarea file before
and after gcc/gen-pass-instances.awk non-functional changes is
sufficient testing. That's also what I'm doing.
Thanks,
- Tom
prev parent reply other threads:[~2015-11-13 10:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 10:09 Tom de Vries
2015-11-13 8:58 ` Thomas Schwinge
2015-11-13 10:29 ` Tom de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5645BB5C.6030601@mentor.com \
--to=tom_devries@mentor.com \
--cc=gcc-patches@gnu.org \
--cc=thomas@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).