From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90892 invoked by alias); 13 Nov 2015 10:29:31 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 90879 invoked by uid 89); 13 Nov 2015 10:29:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: fencepost.gnu.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (208.118.235.10) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 13 Nov 2015 10:29:29 +0000 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39414) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ZxBbh-0007aP-Rz for gcc-patches@gnu.org; Fri, 13 Nov 2015 05:29:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZxBbc-0006nE-7b for gcc-patches@gnu.org; Fri, 13 Nov 2015 05:29:25 -0500 Received: from relay1.mentorg.com ([192.94.38.131]:50440) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZxBbc-0006k9-1T for gcc-patches@gnu.org; Fri, 13 Nov 2015 05:29:20 -0500 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1ZxBbX-0004a5-Ci from Tom_deVries@mentor.com for gcc-patches@gnu.org; Fri, 13 Nov 2015 02:29:15 -0800 Received: from [127.0.0.1] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.224.2; Fri, 13 Nov 2015 10:29:14 +0000 Subject: Re: [committed] gen-pass-instances.awk: Simplify match regexp in handle_line To: Thomas Schwinge References: <56446540.5040808@mentor.com> <87d1vetgwf.fsf@kepler.schwinge.homeip.net> CC: "gcc-patches@gnu.org" From: Tom de Vries Message-ID: <5645BB5C.6030601@mentor.com> Date: Fri, 13 Nov 2015 10:29:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <87d1vetgwf.fsf@kepler.schwinge.homeip.net> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Windows NT kernel [generic] [fuzzy] X-Received-From: 192.94.38.131 X-SW-Source: 2015-11/txt/msg01646.txt.bz2 On 13/11/15 09:58, Thomas Schwinge wrote: > Hi Tom! > > As I happend to see this, and have a number of older build trees around: > > On Thu, 12 Nov 2015 11:09:04 +0100, Tom de Vries wrote: >> this patch [and another dozen of such patches before] simplifies [...] in >> gen-pass-instances.awk. >> >> Committed to trunk as trivial. > > Supposing this was the intention, just to confirm: the generated > gcc/pass-instances.def files that I looked at did not change after your > recent gcc/gen-pass-instances.awk changes. > Hi Thomas, thanks for double-checking and letting me know. Indeed, that was the intention. I intend to change gen-pass-instances.awk for PR68247 - "Remove pass_first_instance", and I'm trying to achieve a minimal diff that contains functional changes, by splitting of trivial improvements that do not contain functional changes. And agreed, comparing the gcc/pass-instances.def buildarea file before and after gcc/gen-pass-instances.awk non-functional changes is sufficient testing. That's also what I'm doing. Thanks, - Tom