public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Martin Liška" <mliska@suse.cz>
To: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix PR ipa/68035
Date: Fri, 13 Nov 2015 12:07:00 -0000	[thread overview]
Message-ID: <5645D299.6060902@suse.cz> (raw)
In-Reply-To: <20151112184000.GA66491@kam.mff.cuni.cz>

On 11/12/2015 07:40 PM, Jan Hubicka wrote:
>>>> +
>>>> +      /* Initialize hash values if we are not in LTO mode.  */
>>>> +      if (!in_lto_p)
>>>> +	item->get_hash ();
>>>>      }
>>>
>>> Hmm, what is the difference to the LTO mode here. I would have expected that all the items
>>> was analyzed in both paths?
>>
>> Difference is that in case of the LTO mode, the hash value is read from streamed LTO file.
>> On the other hand, in classic compilation mode we have to force the calculation as a hash value
>> is computed lazily.
> 
> In this case we need to also handle cases where function/variable is born during WPA (i.e. produced
> by earlier pass), so in_lto_p check looks wrong.
> I will look at the updated patch.
> 
> Honza
> 

Hi Honza.

Currently we just register {cgraph,varpool}_removal_hooks in WPA.
Probably place for enhancement?

Thanks,
Martin

  reply	other threads:[~2015-11-13 12:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-06  9:10 Martin Liška
2015-11-06 13:13 ` Richard Biener
2015-11-06 16:44 ` Jan Hubicka
2015-11-12  9:50   ` Martin Liška
2015-11-12 18:40     ` Jan Hubicka
2015-11-13 12:07       ` Martin Liška [this message]
2015-11-12  9:48 ` [PATCH] Fix PR ipa/68035 (v2) Martin Liška
2015-11-12 11:23   ` Richard Biener

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5645D299.6060902@suse.cz \
    --to=mliska@suse.cz \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).