From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7822 invoked by alias); 13 Nov 2015 18:05:52 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 7811 invoked by uid 89); 13 Nov 2015 18:05:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (207.82.80.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Nov 2015 18:05:51 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-26-eQHC9qq3TRStV_ADgrAfgg-1; Fri, 13 Nov 2015 18:05:46 +0000 Received: from e105915-lin.cambridge.arm.com ([10.1.2.79]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Fri, 13 Nov 2015 18:05:45 +0000 Subject: Re: [PATCH] Fix PR56118 To: Richard Biener , gcc-patches@gcc.gnu.org References: From: Alan Lawrence Message-ID: <56462679.5040908@arm.com> Date: Fri, 13 Nov 2015 18:05:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: X-MC-Unique: eQHC9qq3TRStV_ADgrAfgg-1 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg01755.txt.bz2 On 10/11/15 09:34, Richard Biener wrote: > > The following fixes PR56118 by adjusting the cost model handling of > basic-block vectorization to favor the vectorized version in case > estimated cost is the same as the estimated cost of the scalar > version. This makes sense because we over-estimate the vectorized > cost in several places. > > Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. > > Richard. > > 2015-11-10 Richard Biener > > PR tree-optimization/56118 > * tree-vect-slp.c (vect_bb_vectorization_profitable_p): Make equal > cost favor vectorized version. > > * gcc.target/i386/pr56118.c: New testcase. On AArch64 and ARM targets, this causes PASS->FAIL of gcc.dg/vect/bb-slp-32.c scan-tree-dump slp2 "vectorization is not profitabl= e" gcc.dg/vect/bb-slp-32.c -flto -ffat-lto-objects scan-tree-dump slp2=20 "vectorization is not profitable" ....that sounds like a good thing ;), so I imagine the xfail directive may = just=20 need updating. The test also looks to be failing on powerpc64 (according to= =20 https://gcc.gnu.org/ml/gcc-testresults/2015-11/msg01327.html). Regards, Alan