From: Kyrill Tkachov <kyrylo.tkachov@arm.com>
To: Bernd Schmidt <bschmidt@redhat.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Cc: Jeff Law <law@redhat.com>
Subject: Re: [PATCH][RTL-ree] PR rtl-optimization/68194: Restrict copy instruction in presence of conditional moves
Date: Tue, 17 Nov 2015 13:03:00 -0000 [thread overview]
Message-ID: <564B259A.90206@arm.com> (raw)
In-Reply-To: <564B1934.6050300@redhat.com>
On 17/11/15 12:10, Bernd Schmidt wrote:
> On 11/17/2015 10:08 AM, Kyrill Tkachov wrote:
>> Yes, I had considered that as well. It should be equivalent. I didn't
>> use !reg_used_between_p because I thought
>> it'd be more expensive than checking reg_overlap_mentioned_p since we
>> must iterate over a number of instructions
>> and call reg_overlap_mentioned_p on each one. But I suppose this case is
>> rare enough that it wouldn't make any
>> measurable difference.
>>
>> Would you prefer to use !reg_used_between_p here?
>
> I would but apparently it doesn't work, so that's kind of neither here nor there.
>
>>> The added comment could lead to some confusion since it's placed in
>>> front of an existing if statement that also tests a different
>>> condition. Also, if we go with your fix,
>>>
>>>> + || !reg_overlap_mentioned_p (tmp_reg, SET_SRC (PATTERN
>>>> (cand->insn))))
>>>
>>> Shouldn't this really be !rtx_equal_p?
>>>
>>
>> Maybe, will it behave the right way if the two regs have different modes
>> or when subregs are involved?
>
> It would return false, in which case we'll conservatively fail here. I think that's desirable?
>
Well, I think the statement we want to make is
"return false from this function if the two expressions contain the same register number".
if (!rtx_equal_p (..., ...))
return false;
will only return false if the two expressions are the same REG with the same mode.
if (!reg_overlap_mentioned_p (..., ...))
return false;
should return false even if the modes are different or one is a subreg, which is what we want.
I did not see any codegen regressions using reg_overlap_mentioned_p on aarch64, so I don't think
it will restrict any legitimate cases.
Thanks,
Kyrill
>
> Bernd
>
next prev parent reply other threads:[~2015-11-17 13:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 14:08 Kyrill Tkachov
2015-11-16 18:41 ` Bernd Schmidt
2015-11-17 9:08 ` Kyrill Tkachov
2015-11-17 9:49 ` Kyrill Tkachov
2015-11-17 10:17 ` Kyrill Tkachov
2015-11-17 12:10 ` Bernd Schmidt
2015-11-17 13:03 ` Kyrill Tkachov [this message]
2015-11-17 23:11 ` Bernd Schmidt
2015-11-18 9:11 ` Kyrill Tkachov
2015-11-19 10:28 ` Kyrill Tkachov
2015-11-20 1:41 ` Bernd Schmidt
2015-11-20 9:16 ` Kyrill Tkachov
2015-11-23 15:12 ` Kyrill Tkachov
2015-11-24 13:33 ` Kyrill Tkachov
2015-11-24 13:42 ` Bernd Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564B259A.90206@arm.com \
--to=kyrylo.tkachov@arm.com \
--cc=bschmidt@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).