From: Cesar Philippidis <cesar@codesourcery.com>
To: James Norris <jnorris@codesourcery.com>,
Jakub Jelinek <jakub@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Fortran List <fortran@gcc.gnu.org>
Subject: Re: Re: OpenACC declare directive updates
Date: Wed, 18 Nov 2015 20:09:00 -0000 [thread overview]
Message-ID: <564CDAFB.6030206@codesourcery.com> (raw)
In-Reply-To: <564026AD.5000402@codesourcery.com>
On 11/08/2015 08:53 PM, James Norris wrote:
> The attached patch and ChangeLog reflect the updates from your
> review: https://gcc.gnu.org/ml/gcc-patches/2015-11/msg00714.html
> and Cesar's review:
> https://gcc.gnu.org/ml/gcc-patches/2015-11/msg00885.html.
>
> With the changes made in this patch I think I'm handling the
> situation that you pointed out here correctly:
>
> "Also, wonder about BLOCK stmt in Fortran, that can give you variables that
> don't live through the whole function, but only a portion of it even in
> Fortran."
What block stmt? The most recent version of Fortran OpenACC 2.0a
supports is 2003. The block construct is a 2008 feature. I don't think
that's applicable to this version. Jim, maybe you should add an error
message for variables defined in blocks.
Thinking about this some more, I wonder if we should emit an error if
any acc constructs are used inside blocks? That's probably overly
pessimistic though.
Cesar
next prev parent reply other threads:[~2015-11-18 20:09 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 13:46 James Norris
2015-11-04 12:32 ` James Norris
2015-11-06 13:46 ` James Norris
2015-11-06 19:31 ` Jakub Jelinek
2015-11-06 19:45 ` James Norris
2015-11-06 19:49 ` Jakub Jelinek
2015-11-06 20:20 ` James Norris
2015-11-19 16:22 ` James Norris
2015-11-20 10:53 ` Jakub Jelinek
2015-11-27 11:41 ` [gomp4] " Thomas Schwinge
2019-06-18 23:02 ` [committed] [PR85221] Set 'omp declare target', 'omp declare target link' attributes for Fortran OpenACC 'declare'd variables (was: [gomp4] Re: OpenACC declare directive updates) Thomas Schwinge
2015-11-08 15:29 ` OpenACC declare directive updates James Norris
2015-11-09 2:30 ` Cesar Philippidis
2015-11-09 4:53 ` James Norris
2015-11-18 20:09 ` Cesar Philippidis [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-10-27 20:20 [OpenACC] declare directive James Norris
2015-10-28 16:33 ` Cesar Philippidis
2015-10-28 16:33 ` James Norris
2015-11-03 16:31 ` James Norris
2015-11-04 16:49 ` Thomas Schwinge
2015-11-04 17:12 ` James Norris
2015-11-06 16:08 ` James Norris
2015-11-06 16:16 ` James Norris
2015-11-06 19:04 ` Jakub Jelinek
2015-11-06 19:23 ` Jakub Jelinek
2015-11-06 20:18 ` James Norris
2015-11-06 20:28 ` Jakub Jelinek
2015-11-06 20:35 ` James Norris
2015-11-06 20:16 ` James Norris
2015-11-08 15:35 ` James Norris
2015-11-09 16:01 ` James Norris
2015-11-09 16:21 ` Jakub Jelinek
2015-11-09 16:31 ` James Norris
2015-11-09 23:11 ` James Norris
2015-11-11 8:32 ` Jakub Jelinek
2015-11-11 10:08 ` Thomas Schwinge
2015-11-11 17:29 ` Jakub Jelinek
2015-11-12 1:08 ` James Norris
2015-11-12 9:10 ` Jakub Jelinek
2015-11-12 13:34 ` James Norris
2015-11-23 12:41 ` Thomas Schwinge
2015-11-24 8:45 ` [gomp4] " Thomas Schwinge
2015-11-12 23:25 ` [PATCH] Fix unused variable James Norris
2015-11-22 19:11 ` [PATCH] fortran/openmp.c -- Fix bootstrap Steve Kargl
2015-11-22 19:27 ` Jerry DeLisle
2015-11-22 20:38 ` James Norris
2019-06-18 22:45 ` [committed] Fix description of 'GOMP_MAP_FIRSTPRIVATE' (was: [OpenACC] declare directive) Thomas Schwinge
2019-06-18 22:21 ` [committed] [PR90862] OpenACC 'declare' ICE when nested inside another construct " Thomas Schwinge
2015-11-06 13:48 ` [OpenACC] declare directive James Norris
2021-06-10 11:15 ` Thomas Schwinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564CDAFB.6030206@codesourcery.com \
--to=cesar@codesourcery.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jnorris@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).