From: Bernd Schmidt <bschmidt@redhat.com>
To: Ilya Enkovich <enkovich.gnu@gmail.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH, PR68337] Don't fold memcpy/memmove we want to instrument
Date: Thu, 19 Nov 2015 17:12:00 -0000 [thread overview]
Message-ID: <564E02FE.5020503@redhat.com> (raw)
In-Reply-To: <20151119163110.GG42296@msticlxl57.ims.intel.com>
On 11/19/2015 05:31 PM, Ilya Enkovich wrote:
> Currently we fold all memcpy/memmove calls with a known data size.
> It causes two problems when used with Pointer Bounds Checker.
> The first problem is that we may copy pointers as integer data
> and thus loose bounds. The second problem is that if we inline
> memcpy, we also have to inline bounds copy and this may result
> in a huge amount of code and significant compilation time growth.
> This patch disables folding for functions we want to instrument.
>
> Does it look reasonable for trunk and GCC5 branch? Bootstrapped
> and regtested on x86_64-unknown-linux-gnu.
Can't see anything wrong with it. Ok.
Bernd
next prev parent reply other threads:[~2015-11-19 17:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 16:31 Ilya Enkovich
2015-11-19 17:12 ` Bernd Schmidt [this message]
2015-11-19 17:19 ` Richard Biener
2015-11-20 13:08 ` Ilya Enkovich
2015-11-20 13:54 ` Richard Biener
2015-11-20 14:30 ` Ilya Enkovich
2015-11-23 9:40 ` Richard Biener
2015-11-23 10:12 ` Ilya Enkovich
2015-11-23 10:55 ` Richard Biener
2015-11-23 11:41 ` Ilya Enkovich
2015-11-23 13:31 ` Richard Biener
2015-11-23 13:47 ` Ilya Enkovich
2015-11-23 15:35 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564E02FE.5020503@redhat.com \
--to=bschmidt@redhat.com \
--cc=enkovich.gnu@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).