public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <law@redhat.com>
To: Senthil Kumar Selvaraj <senthil_kumar.selvaraj@atmel.com>,
	       Richard Biener <rguenther@suse.de>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [Patch, vrp] Allow VRP type conversion folding only for widenings upto word mode
Date: Thu, 19 Nov 2015 17:31:00 -0000	[thread overview]
Message-ID: <564E077D.4020908@redhat.com> (raw)
In-Reply-To: <20151119062014.GA2345@jaguar.corp.atmel.com>

On 11/18/2015 11:20 PM, Senthil Kumar Selvaraj wrote:
> On Wed, Nov 18, 2015 at 09:36:21AM +0100, Richard Biener wrote:
>>
>> Otherwise ok.
>
> See modified patch below. If you think vrp98.c is unnecessary, feel free
> to dump it :).
>
> If ok, could you commit it for me please? I don't have commit access.
>
> Regards
> Senthil
>
> gcc/ChangeLog
> 2015-11-19  Senthil Kumar Selvaraj  <senthil_kumar.selvaraj@atmel.com>
>
> 	* tree.h (desired_pro_or_demotion_p): New function.
> 	* tree-vrp.c (simplify_cond_using_ranges): Call it.
>
> gcc/testsuite/ChangeLog
> 2015-11-19  Senthil Kumar Selvaraj  <senthil_kumar.selvaraj@atmel.com>
>
> 	* gcc.dg/tree-ssa/vrp98.c: New testcase.
> 	* gcc.target/avr/uint8-single-reg.c: New testcase.
I went ahead and committed this as-is.

I do think the vrp98 testcase is useful as it verifies that VRP is doing 
what we want in a target independent way.  It's a good complement to the 
AVR specific testcase.

Thanks,
Jeff

  reply	other threads:[~2015-11-19 17:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-14  7:12 Senthil Kumar Selvaraj
2015-11-14  8:13 ` Marc Glisse
2015-11-14  8:50   ` Senthil Kumar Selvaraj
2015-11-14  8:57     ` Richard Biener
2015-11-14 18:11       ` Senthil Kumar Selvaraj
2015-11-16  9:02         ` Richard Biener
2015-11-17 19:53           ` Senthil Kumar Selvaraj
2015-11-18  8:36             ` Richard Biener
2015-11-19  6:20               ` Senthil Kumar Selvaraj
2015-11-19 17:31                 ` Jeff Law [this message]
2015-11-20 17:04                   ` Senthil Kumar Selvaraj
2015-11-20 17:34                     ` Jeff Law
2015-11-23  9:54                       ` Richard Biener

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=564E077D.4020908@redhat.com \
    --to=law@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=rguenther@suse.de \
    --cc=senthil_kumar.selvaraj@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).