From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97604 invoked by alias); 19 Nov 2015 18:30:17 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 97585 invoked by uid 89); 19 Nov 2015 18:30:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 19 Nov 2015 18:30:16 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 12DEB65667 for ; Thu, 19 Nov 2015 18:30:15 +0000 (UTC) Received: from [10.10.116.26] (ovpn-116-26.rdu2.redhat.com [10.10.116.26]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tAJIUEZ3013793; Thu, 19 Nov 2015 13:30:14 -0500 Subject: Re: [PATCH] Transactional Memory: Support __cxa_free_exception and fix exception handling. To: Torvald Riegel , GCC Patches References: <1447888923.25500.108.camel@localhost.localdomain> Cc: Richard Henderson From: Jason Merrill Message-ID: <564E1536.1080003@redhat.com> Date: Thu, 19 Nov 2015 18:30:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1447888923.25500.108.camel@localhost.localdomain> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2015-11/txt/msg02407.txt.bz2 On 11/18/2015 06:22 PM, Torvald Riegel wrote: > The EH scheme that we had been using for TM / libitm doesn't work > properly. We fail to handle throwing exceptions whose constructors may > throw themselves. We also do not clean up properly in all situations > when a transactions abort while being in the process of throwing an > exception. > This patch solves this particular problem by adding a transactional > wrapper for __cxa_free_exception and changing the EH scheme in libitm. > > Follow-up patches will fix other issues that we have identified. Some > of the changes to the libitm.texi ABI docs added in this patch already > take this future work into account. > > Tested using the libitm testsuite on x86_64-linux. > > Are the gcc/ bits OK? > > gcc/cp/ > * except.c (do_free_exception): Use transactional wrapper. OK. Jason