From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 123775 invoked by alias); 20 Nov 2015 12:15:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 123762 invoked by uid 89); 20 Nov 2015 12:15:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (207.82.80.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 Nov 2015 12:15:43 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-8-ha25IW_OR-SCvuyvY8Pp4A-1; Fri, 20 Nov 2015 12:15:37 +0000 Received: from [10.2.206.200] ([10.1.2.79]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Fri, 20 Nov 2015 12:15:37 +0000 Message-ID: <564F0EE8.1050901@arm.com> Date: Fri, 20 Nov 2015 12:15:00 -0000 From: Kyrill Tkachov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Kirill Yukhin , Andreas Schwab , David Edelsohn CC: Jakub Jelinek , Joseph Myers , Jeff Law , GCC Patches Subject: Re: [PATCH, VECTOR ABI] Add __attribute__((__simd__)) to GCC. References: <20151023141102.GA63293@msticlxl57.ims.intel.com> <20151027140655.GC46998@msticlxl57.ims.intel.com> <20151027141505.GG478@tucnak.redhat.com> <20151028091601.GA53647@msticlxl57.ims.intel.com> <20151029085447.GP478@tucnak.redhat.com> <20151110084414.GA62112@msticlxl57.ims.intel.com> <20151110085804.GW5675@tucnak.redhat.com> <20151113115430.GA63972@msticlxl57.ims.intel.com> <20151118141103.GB25086@msticlxl57.ims.intel.com> In-Reply-To: <20151118141103.GB25086@msticlxl57.ims.intel.com> X-MC-Unique: ha25IW_OR-SCvuyvY8Pp4A-1 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg02478.txt.bz2 Hi Kirill, On 18/11/15 14:11, Kirill Yukhin wrote: > Hello Andreas, Devid. > > On 18 Nov 10:45, Andreas Schwab wrote: >> Kirill Yukhin writes: >> >>> diff --git a/gcc/testsuite/c-c++-common/attr-simd.c b/gcc/testsuite/c-c= ++-common/attr-simd.c >>> new file mode 100644 >>> index 0000000..b4eda34 >>> --- /dev/null >>> +++ b/gcc/testsuite/c-c++-common/attr-simd.c >>> @@ -0,0 +1,32 @@ >>> +/* { dg-do compile } */ >>> +/* { dg-options "-fdump-tree-optimized" } */ >>> + >>> +__attribute__((__simd__)) >>> +extern >>> +int simd_attr (void) >>> +{ >>> + return 0; >>> +} >>> + >>> +/* { dg-final { scan-tree-dump "simd_attr\[ \\t\]simdclone|vector" "op= timized" } } */ >> On ia64: >> >> FAIL: c-c++-common/attr-simd.c -Wc++-compat scan-tree-dump optimized = "simd_attr[ \\t]simdclone|vector" >> FAIL: c-c++-common/attr-simd.c -Wc++-compat scan-tree-dump optimized = "simd_attr2[ \\t]simdclone|vector" >> >> $ grep simd_attr attr-simd.c.194t.optimized >> ;; Function simd_attr (simd_attr, funcdef_no=3D0, decl_uid=3D1389, cgrap= h_uid=3D0, symbol_order=3D0) >> simd_attr () >> ;; Function simd_attr2 (simd_attr2, funcdef_no=3D1, decl_uid=3D1392, cgr= aph_uid=3D1, symbol_order=3D1) >> simd_attr2 () > As far as vABI is supported on x86_64/i?86 only, I am going to enable men= tioned `scan-tree-dump' only > for these targets. This should cure both IA64 and Power. > > Concerning attr-simd-3.c. It is known issue: PR68158. > And I believe this test should work everywhere as far as PR is resolved. > I'll put xfail into the test. > Which will lead to (in g++.log): > gcc/testsuite/c-c++-common/attr-simd-3.c:5:48: warning: '__simd__' attrib= ute does not apply to types\ > [-Wattributes]^M > output is: > gcc/testsuite/c-c++-common/attr-simd-3.c:5:48: warning: '__simd__' attrib= ute does not apply to types\ > [-Wattributes]^M > > XFAIL: c-c++-common/attr-simd-3.c -std=3Dgnu++98 PR68158 (test for error= s, line 5) > FAIL: c-c++-common/attr-simd-3.c -std=3Dgnu++98 (test for excess errors) > Excess errors: > gcc/testsuite/c-c++-common/attr-simd-3.c:5:48: warning: '__simd__' attrib= ute does not apply to types\ > [-Wattributes] > > Patch in the bottom. > > gcc/tessuite/ > * c-c++-common/attr-simd-3.c: Put xfail (PR68158) on dg-error. This test fails on bare-metal targets that don't support -fcilkplus or -pth= read. Would you consider moving them to the cilkplus testing directory or adding = an appropriate effective target check? Thanks, Kyrill > * c-c++-common/attr-simd.c: Limit scan of dump to x86_64/i?86. > >> Andreas. >> >> --=20 >> Andreas Schwab, SUSE Labs, schwab@suse.de >> GPG Key fingerprint =3D 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9= D7 >> "And now for something completely different." > diff --git a/gcc/testsuite/c-c++-common/attr-simd-3.c b/gcc/testsuite/c-c= ++-common/attr-simd-3.c > index 2bbdf04..35dd4c0 100644 > --- a/gcc/testsuite/c-c++-common/attr-simd-3.c > +++ b/gcc/testsuite/c-c++-common/attr-simd-3.c > @@ -2,4 +2,4 @@ > /* { dg-options "-fcilkplus" } */ > /* { dg-prune-output "undeclared here \\(not in a function\\)|\[^\n\r\]= * was not declared in this scope" } */ > > -void f () __attribute__((__simd__, __vector__)); /* { dg-error "in the s= ame function marked as a Cilk Plus" } */ > +void f () __attribute__((__simd__, __vector__)); /* { dg-error "in the s= ame function marked as a Cilk Plus" "PR68158" { xfail c++ } } */ > diff --git a/gcc/testsuite/c-c++-common/attr-simd.c b/gcc/testsuite/c-c++= -common/attr-simd.c > index 61974e3..7674588 100644 > --- a/gcc/testsuite/c-c++-common/attr-simd.c > +++ b/gcc/testsuite/c-c++-common/attr-simd.c > @@ -11,7 +11,7 @@ int simd_attr (void) > return 0; > } > > -/* { dg-final { scan-tree-dump "simd_attr\[ \\t\]simdclone|vector" "opti= mized" } } */ > +/* { dg-final { scan-tree-dump "simd_attr\[ \\t\]simdclone|vector" "opti= mized" { target { i?86-*-* x86_64-*-* } } } } */ > /* { dg-final { scan-assembler-times "_ZGVbN4_simd_attr:" 1 { target { = i?86-*-* x86_64-*-* } } } } */ > /* { dg-final { scan-assembler-times "_ZGVbM4_simd_attr:" 1 { target { = i?86-*-* x86_64-*-* } } } } */ > /* { dg-final { scan-assembler-times "_ZGVcN4_simd_attr:" 1 { target { = i?86-*-* x86_64-*-* } } } } */ > @@ -29,7 +29,7 @@ int simd_attr2 (void) > return 0; > } > > -/* { dg-final { scan-tree-dump "simd_attr2\[ \\t\]simdclone|vector" "opt= imized" } } */ > +/* { dg-final { scan-tree-dump "simd_attr2\[ \\t\]simdclone|vector" "opt= imized" { target { i?86-*-* x86_64-*-* } } } } */ > /* { dg-final { scan-assembler-times "_ZGVbN4_simd_attr2:" 1 { target {= i?86-*-* x86_64-*-* } } } } */ > /* { dg-final { scan-assembler-times "_ZGVbM4_simd_attr2:" 1 { target {= i?86-*-* x86_64-*-* } } } } */ > /* { dg-final { scan-assembler-times "_ZGVcN4_simd_attr2:" 1 { target {= i?86-*-* x86_64-*-* } } } } */ >