From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115678 invoked by alias); 20 Nov 2015 17:34:24 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 115506 invoked by uid 89); 20 Nov 2015 17:34:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 20 Nov 2015 17:34:23 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 00DB1264E; Fri, 20 Nov 2015 17:34:21 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-91.phx2.redhat.com [10.3.113.91]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tAKHYLaj027881; Fri, 20 Nov 2015 12:34:21 -0500 Subject: Re: [Patch, vrp] Allow VRP type conversion folding only for widenings upto word mode To: Senthil Kumar Selvaraj References: <20151114071148.GA16647@jaguar.atmel.com> <20151114084928.GA749@jaguar.atmel.com> <595F0CF8-27C1-4A63-8339-F70CB5E76CAB@suse.de> <20151114181044.GA1297@jaguar.atmel.com> <20151117195241.GA5579@jaguar.atmel.com> <20151119062014.GA2345@jaguar.corp.atmel.com> <564E077D.4020908@redhat.com> <20151120170410.GA698@jaguar.atmel.com> Cc: Richard Biener , gcc-patches@gcc.gnu.org From: Jeff Law Message-ID: <564F599D.2010109@redhat.com> Date: Fri, 20 Nov 2015 17:34:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151120170410.GA698@jaguar.atmel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg02519.txt.bz2 On 11/20/2015 10:04 AM, Senthil Kumar Selvaraj wrote: > On Thu, Nov 19, 2015 at 10:31:41AM -0700, Jeff Law wrote: >> On 11/18/2015 11:20 PM, Senthil Kumar Selvaraj wrote: >>> On Wed, Nov 18, 2015 at 09:36:21AM +0100, Richard Biener wrote: >>>> >>>> Otherwise ok. >>> >>> See modified patch below. If you think vrp98.c is unnecessary, feel free >>> to dump it :). >>> >>> If ok, could you commit it for me please? I don't have commit access. >>> >>> Regards >>> Senthil >>> >>> gcc/ChangeLog >>> 2015-11-19 Senthil Kumar Selvaraj >>> >>> * tree.h (desired_pro_or_demotion_p): New function. >>> * tree-vrp.c (simplify_cond_using_ranges): Call it. >>> >>> gcc/testsuite/ChangeLog >>> 2015-11-19 Senthil Kumar Selvaraj >>> >>> * gcc.dg/tree-ssa/vrp98.c: New testcase. >>> * gcc.target/avr/uint8-single-reg.c: New testcase. >> I went ahead and committed this as-is. >> >> I do think the vrp98 testcase is useful as it verifies that VRP is doing >> what we want in a target independent way. It's a good complement to the AVR >> specific testcase. > > I see the same problem on gcc-5-branch as well. Would it be ok to > backport the fix to that branch as well? That's a call for the release managers. I typically don't backport anything expect ICE or incorrect code generation fixes as I tend to be very conservative on what goes onto a release branch. Jakub, Richi or Joseph would need to ack into a release branch. jeff