From: Jeff Law <jeffreyalaw@gmail.com>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>, gcc-patches@gcc.gnu.org
Cc: Alexandre Oliva <aoliva@gcc.gnu.org>
Subject: Re: [PATCH] build: Check that -lzstd can be linked
Date: Sun, 2 Apr 2023 15:15:31 -0600 [thread overview]
Message-ID: <565319eb-ccc9-bcd2-3141-ef0adbb113fc@gmail.com> (raw)
In-Reply-To: <yddmt3xui33.fsf@CeBiTec.Uni-Bielefeld.DE>
On 3/28/23 07:21, Rainer Orth wrote:
> Recent Solaris 11.4 SRUs bundle zstd, but only the 64-bit libraries (no
> idea why). Because of this, in 32-bit builds cc1 etc. fail to link with
> undefined references to various ZSTD_* functions from lto-compress.o.
> This happens because currently only the presence of <zstd.h> is
> necessary to enable zstd support in lto-compress.cc etc.
>
> This patch checks for libzstd first and disables zstd support if
> missing.
>
> Tested on sparc-sun-solaris2.11 with the system installation of zstd
> (64-bit only) and a locally-compiled one (specified with --with-zstd).
>
> Ok for trunk?
OK
jeff
prev parent reply other threads:[~2023-04-02 21:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 13:21 Rainer Orth
2023-04-02 21:15 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565319eb-ccc9-bcd2-3141-ef0adbb113fc@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=aoliva@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).