From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129713 invoked by alias); 23 Nov 2015 14:56:23 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 129061 invoked by uid 89); 23 Nov 2015 14:56:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS,UNSUBSCRIBE_BODY autolearn=no version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (207.82.80.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 23 Nov 2015 14:56:22 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-22-ASyorIi8S4GBJ606QBghoA-1; Mon, 23 Nov 2015 14:56:16 +0000 Received: from [10.2.206.40] ([10.1.2.79]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 23 Nov 2015 14:56:16 +0000 Message-ID: <56532910.7030305@arm.com> Date: Mon, 23 Nov 2015 14:58:00 -0000 From: Szabolcs Nagy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: "gcc-patches@gcc.gnu.org" CC: Richard Earnshaw , Ramana Radhakrishnan Subject: Re: [PATCH, ARM, v2] PR target/68059 libgcc should not use __write for printing fatal error References: <563CAC08.7050109@arm.com> In-Reply-To: <563CAC08.7050109@arm.com> X-MC-Unique: ASyorIi8S4GBJ606QBghoA-1 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg02735.txt.bz2 On 06/11/15 13:32, Szabolcs Nagy wrote: > libgcc/config/arm/linux-atomic-64bit.c uses __write to print an error > message if the 64bit cmpxchg method is not available in the kernel. > > __write is not part of the public libc abi, so use write instead. > (user code may define write in iso c conforming mode and then the > error message may not be visible before the crash.) > > The return type in the declaration of write is fixed too. > > OK for trunk and backporting? > ping. > libgcc/ChangeLog: > > 2015-11-06 Szabolcs Nagy > > PR target/68059 > * config/arm/linux-atomic-64bit.c (__write): Rename to... > (write): ...this and fix the return type.