From: Richard Earnshaw <Richard.Earnshaw@foss.arm.com>
To: Szabolcs Nagy <szabolcs.nagy@arm.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>
Subject: Re: [PATCH, ARM, v2] PR target/68059 libgcc should not use __write for printing fatal error
Date: Mon, 23 Nov 2015 15:01:00 -0000 [thread overview]
Message-ID: <565329B9.8070106@foss.arm.com> (raw)
In-Reply-To: <563CAC08.7050109@arm.com>
On 06/11/15 13:32, Szabolcs Nagy wrote:
> libgcc/config/arm/linux-atomic-64bit.c uses __write to print an error
> message if the 64bit cmpxchg method is not available in the kernel.
>
> __write is not part of the public libc abi, so use write instead.
> (user code may define write in iso c conforming mode and then the
> error message may not be visible before the crash.)
>
> The return type in the declaration of write is fixed too.
>
> OK for trunk and backporting?
>
> libgcc/ChangeLog:
>
> 2015-11-06 Szabolcs Nagy <szabolcs.nagy@arm.com>
>
> PR target/68059
> * config/arm/linux-atomic-64bit.c (__write): Rename to...
> (write): ...this and fix the return type.
>
OK.
R.
prev parent reply other threads:[~2015-11-23 14:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-06 13:33 Szabolcs Nagy
2015-11-23 14:58 ` Szabolcs Nagy
2015-11-23 15:01 ` Richard Earnshaw [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565329B9.8070106@foss.arm.com \
--to=richard.earnshaw@foss.arm.com \
--cc=Ramana.Radhakrishnan@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=szabolcs.nagy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).