From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-415021-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 15462 invoked by alias); 23 Nov 2015 14:59:12 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 15451 invoked by uid 89); 23 Nov 2015 14:59:11 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-0.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,UNSUBSCRIBE_BODY autolearn=no version=3.3.2
X-HELO: foss.arm.com
Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 23 Nov 2015 14:59:10 +0000
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B201549;	Mon, 23 Nov 2015 06:58:51 -0800 (PST)
Received: from e105689-lin.cambridge.arm.com (e105689-lin.cambridge.arm.com [10.2.207.32])	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E1D253F51B;	Mon, 23 Nov 2015 06:59:07 -0800 (PST)
Subject: Re: [PATCH, ARM, v2] PR target/68059 libgcc should not use __write for printing fatal error
To: Szabolcs Nagy <szabolcs.nagy@arm.com>, "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
References: <563CAC08.7050109@arm.com>
Cc: Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>
From: Richard Earnshaw <Richard.Earnshaw@foss.arm.com>
Message-ID: <565329B9.8070106@foss.arm.com>
Date: Mon, 23 Nov 2015 15:01:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <563CAC08.7050109@arm.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2015-11/txt/msg02737.txt.bz2

On 06/11/15 13:32, Szabolcs Nagy wrote:
> libgcc/config/arm/linux-atomic-64bit.c uses __write to print an error
> message if the 64bit cmpxchg method is not available in the kernel.
> 
> __write is not part of the public libc abi, so use write instead.
> (user code may define write in iso c conforming mode and then the
> error message may not be visible before the crash.)
> 
> The return type in the declaration of write is fixed too.
> 
> OK for trunk and backporting?
> 
> libgcc/ChangeLog:
> 
> 2015-11-06  Szabolcs Nagy  <szabolcs.nagy@arm.com>
> 
>     PR target/68059
>     * config/arm/linux-atomic-64bit.c (__write): Rename to...
>     (write): ...this and fix the return type.
> 

OK.

R.