From: Bernd Schmidt <bschmidt@redhat.com>
To: David Malcolm <dmalcolm@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] PR c/68473: sanitize source range-printing within certain macro expansions
Date: Mon, 23 Nov 2015 18:13:00 -0000 [thread overview]
Message-ID: <565353E6.2060403@redhat.com> (raw)
In-Reply-To: <1448301150-13289-1-git-send-email-dmalcolm@redhat.com>
On 11/23/2015 06:52 PM, David Malcolm wrote:
> This patch fixes PR c/68473 by bulletproofing the new
> diagnostic_show_locus implementation against ranges that finish before
> they start (which can happen when using the C preprocessor), falling
> back to simply printing a caret.
Hmm, wouldn't it be better to avoid such a situation? Can you describe a
bit more how exactly the macro expansion caused such a situation?
Bernd
next prev parent reply other threads:[~2015-11-23 17:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 17:59 David Malcolm
2015-11-23 18:13 ` Bernd Schmidt [this message]
2015-11-23 18:37 ` David Malcolm
2015-11-24 12:44 ` Bernd Schmidt
2015-12-11 18:25 ` [PATCH 0/3] " David Malcolm
2015-12-11 18:25 ` [PATCH 3/3] PR c/68473: sanitize source range-printing within certain macro expansions (v2) David Malcolm
2015-12-11 18:25 ` [PATCH 2/3] Fix range/location terminology David Malcolm
2015-12-11 18:25 ` [PATCH 1/3] Delay location expansion within rich_location until printing David Malcolm
2015-12-14 12:39 ` [PATCH 0/3] Re: [PATCH] PR c/68473: sanitize source range-printing within certain macro expansions Bernd Schmidt
2015-12-10 16:24 ` Martin Sebor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565353E6.2060403@redhat.com \
--to=bschmidt@redhat.com \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).