From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117226 invoked by alias); 23 Nov 2015 17:59:07 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 114641 invoked by uid 89); 23 Nov 2015 17:59:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 23 Nov 2015 17:59:05 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 78F79A327F for ; Mon, 23 Nov 2015 17:59:04 +0000 (UTC) Received: from localhost.localdomain (vpn1-5-8.ams2.redhat.com [10.36.5.8]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tANHx3QV018540; Mon, 23 Nov 2015 12:59:03 -0500 Subject: Re: [PATCH] PR c/68473: sanitize source range-printing within certain macro expansions To: David Malcolm , gcc-patches@gcc.gnu.org References: <1448301150-13289-1-git-send-email-dmalcolm@redhat.com> From: Bernd Schmidt Message-ID: <565353E6.2060403@redhat.com> Date: Mon, 23 Nov 2015 18:13:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1448301150-13289-1-git-send-email-dmalcolm@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg02773.txt.bz2 On 11/23/2015 06:52 PM, David Malcolm wrote: > This patch fixes PR c/68473 by bulletproofing the new > diagnostic_show_locus implementation against ranges that finish before > they start (which can happen when using the C preprocessor), falling > back to simply printing a caret. Hmm, wouldn't it be better to avoid such a situation? Can you describe a bit more how exactly the macro expansion caused such a situation? Bernd