From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12319 invoked by alias); 23 Nov 2015 19:54:34 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 12307 invoked by uid 89); 23 Nov 2015 19:54:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 23 Nov 2015 19:54:33 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id ED0FF65678; Mon, 23 Nov 2015 19:54:31 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-91.phx2.redhat.com [10.3.113.91]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tANJsVJg007027; Mon, 23 Nov 2015 14:54:31 -0500 Subject: Re: [PATCH 5/6] Fix parser memory leak in cilk_simd_fn_info To: marxin , gcc-patches@gcc.gnu.org References: <176c035591885aaf8fa1c2508b1804e187f3f770.1448286565.git.mliska@suse.cz> From: Jeff Law Message-ID: <56536EF7.1060500@redhat.com> Date: Mon, 23 Nov 2015 20:13:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <176c035591885aaf8fa1c2508b1804e187f3f770.1448286565.git.mliska@suse.cz> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg02785.txt.bz2 On 11/23/2015 06:48 AM, marxin wrote: > gcc/cp/ChangeLog: > > 2015-11-23 Martin Liska > > * parser.c (cp_parser_late_parsing_cilk_simd_fn_info): > Release tokens. There's a vec of objects in cilk_simd_fn_info, so unless that vec is copied elsewhere, we definitely want to release them before we blow away parser->cilk_simd_fn_info. AFAICT the vec is never copied elsewhere. So... OK for the trunk. jeff