From: Jeff Law <law@redhat.com>
To: Nathan Sidwell <nathan@acm.org>, GCC Patches <gcc-patches@gcc.gnu.org>
Cc: Bernd Schmidt <bschmidt@redhat.com>
Subject: Re: [ptx] Fix sso tests
Date: Mon, 23 Nov 2015 20:45:00 -0000 [thread overview]
Message-ID: <56537A17.20002@redhat.com> (raw)
In-Reply-To: <5653740C.9010507@acm.org>
On 11/23/2015 01:16 PM, Nathan Sidwell wrote:
> The gcc.dg/sso tests gratuitously fail on PTX because they use IO
> facilities that don't exist there. This patch changes the dumping to
> use the putchar function call (and not a macro), and not use fputs.
>
> With this they all pass.
>
> I'm not quite sure where the maintainer boundaries lie for this kind of
> fix. Any objections?
In the 'put' function, why not just make all targets go through putchar?
It's not like this is performance critical code and I don't think it
compromises any of the tests, does it?
jeff
next prev parent reply other threads:[~2015-11-23 20:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 20:20 Nathan Sidwell
2015-11-23 20:45 ` Jeff Law [this message]
2015-11-23 21:00 ` Nathan Sidwell
2015-11-24 5:38 ` Jeff Law
2015-11-24 14:03 ` Nathan Sidwell
2015-11-24 8:20 ` Thomas Schwinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56537A17.20002@redhat.com \
--to=law@redhat.com \
--cc=bschmidt@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nathan@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).