From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127109 invoked by alias); 24 Nov 2015 05:01:07 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 127096 invoked by uid 89); 24 Nov 2015 05:01:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 24 Nov 2015 05:01:06 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id B08B7461C7; Tue, 24 Nov 2015 05:01:04 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-91.phx2.redhat.com [10.3.113.91]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tAO514eb021712; Tue, 24 Nov 2015 00:01:04 -0500 Subject: Re: [ptx] Fix sso tests To: Nathan Sidwell , GCC Patches References: <5653740C.9010507@acm.org> <56537A17.20002@redhat.com> <56537CF6.8030501@acm.org> Cc: Bernd Schmidt From: Jeff Law Message-ID: <5653EF0F.6090301@redhat.com> Date: Tue, 24 Nov 2015 05:38:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <56537CF6.8030501@acm.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg02819.txt.bz2 On 11/23/2015 01:54 PM, Nathan Sidwell wrote: > On 11/23/15 15:41, Jeff Law wrote: > > >> In the 'put' function, why not just make all targets go through >> putchar? It's not like this is performance critical code and I >> don't think it compromises any of the tests, does it? > > I contemplated that, but wondered if someone would complain. I'm > happy either way. Let's go with a single codepath here. The one that ought to work for all targets is putchar. Thanks, jeff