From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24829 invoked by alias); 26 Nov 2015 14:37:00 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 24728 invoked by uid 89); 26 Nov 2015 14:36:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: fencepost.gnu.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (208.118.235.10) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 26 Nov 2015 14:36:58 +0000 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52297) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1a1xfM-0006Ku-3B for gcc-patches@gnu.org; Thu, 26 Nov 2015 09:36:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1xfH-0007K8-Ka for gcc-patches@gnu.org; Thu, 26 Nov 2015 09:36:55 -0500 Received: from relay1.mentorg.com ([192.94.38.131]:34770) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1xfH-0007Jv-Ey for gcc-patches@gnu.org; Thu, 26 Nov 2015 09:36:51 -0500 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1a1xfE-0006Mg-Dk from Tom_deVries@mentor.com ; Thu, 26 Nov 2015 06:36:48 -0800 Received: from [127.0.0.1] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.224.2; Thu, 26 Nov 2015 14:36:47 +0000 Subject: Re: [PATCH] Improve verification of loop->latch in verify_loop_structure To: Richard Biener , Alan Lawrence References: <56524E0D.7000203@mentor.com> <56547D49.5040609@mentor.com> CC: "gcc-patches@gnu.org" , Jakub Jelinek From: Tom de Vries Message-ID: <565718CA.8050704@mentor.com> Date: Thu, 26 Nov 2015 14:44:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Windows NT kernel [generic] [fuzzy] X-Received-From: 192.94.38.131 X-SW-Source: 2015-11/txt/msg03247.txt.bz2 On 26/11/15 13:15, Richard Biener wrote: > On Thu, 26 Nov 2015, Alan Lawrence wrote: > >> This caused an ICE compiling value.c from gdb on >> aarch64-none-linux-gnu; the testcase, after preprocessing on aarch64, >> ICEs on both aarch64 and x86_64, but is about 1MB - I'm working on >> reducing that down to something small enough to post... >> >> $ ./gcc/xgcc -B ./gcc -O2 -g value.c >> ../../binutils-gdb/gdb/value.c: In function ‘show_convenience’: >> ../../binutils-gdb/gdb/value.c:2615:1: error: loop 3’s latch is missing >> ../../binutils-gdb/gdb/value.c:2615:1: internal compiler error: in >> verify_loop_structure, at cfgloop.c:1669 >> 0x71e653 verify_loop_structure() >> /work/alalaw01/src2/gcc/gcc/cfgloop.c:1669 >> 0x97c6ae checking_verify_loop_structure >> /work/alalaw01/src2/gcc/gcc/cfgloop.h:325 >> 0x97c6ae loop_optimizer_init(unsigned int) >> /work/alalaw01/src2/gcc/gcc/loop-init.c:106 >> 0x97c78a rtl_loop_init >> /work/alalaw01/src2/gcc/gcc/loop-init.c:398 >> 0x97c78a execute >> /work/alalaw01/src2/gcc/gcc/loop-init.c:425 > > See also PR68549 for why I think this happens "by design". Thus > I think we need to revert the checking when > LOOPS_MAY_HAVE_MULTIPLE_LATCHES for now. I'll revert the whole patch for now. Thanks, - Tom