From: Bernd Schmidt <bschmidt@redhat.com>
To: Eric Botcazou <ebotcazou@adacore.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: regrename/i386: ROP vs df and stack-regs
Date: Fri, 27 Nov 2015 09:36:00 -0000 [thread overview]
Message-ID: <565822C4.1030102@redhat.com> (raw)
In-Reply-To: <3562780.Gh8PD94ruK@polaris>
On 11/27/2015 10:26 AM, Eric Botcazou wrote:
> +#ifdef STACK_REGS
> + if (regstack_completed
> + && REG_P (recog_data.operand[i])
> + && IN_RANGE (REGNO (recog_data.operand[i]),
> + FIRST_STACK_REG, LAST_STACK_REG))
> + untracked_operands |= 1 << i;
> +#endif
>
> Why not use "op" instead of recog_data.operand[i] here? Don't this need to be
> placed before the conditional call to create_new_chain?
Both good points. Ok with those changes (will retest)?
Bernd
next prev parent reply other threads:[~2015-11-27 9:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 9:21 Bernd Schmidt
2015-11-27 9:30 ` Eric Botcazou
2015-11-27 9:36 ` Bernd Schmidt [this message]
2015-11-27 9:45 ` Eric Botcazou
2015-11-30 21:47 ` Bernd Schmidt
2015-11-30 22:06 ` Uros Bizjak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565822C4.1030102@redhat.com \
--to=bschmidt@redhat.com \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).