From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47112 invoked by alias); 30 Nov 2015 19:40:50 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 47093 invoked by uid 89); 30 Nov 2015 19:40:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: smtp.fgznet.ch Received: from smtp.fgznet.ch (HELO smtp.fgznet.ch) (157.161.14.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 30 Nov 2015 19:40:48 +0000 Received: from [192.168.225.14] (dhclient-91-190-14-19.flashcable.ch [91.190.14.19]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by fgznet.ch (Postfix) with ESMTPS id 95CB0CDAFA; Mon, 30 Nov 2015 20:40:45 +0100 (CET) Subject: Re: [patch] c/c++ asan tests for FreeBSD To: Jakub Jelinek , Bernd Schmidt References: <565B52BD.3020405@fgznet.ch> <565C24BE.8020905@redhat.com> <565C3D16.9020708@fgznet.ch> <565C7699.5020405@redhat.com> <20151130162247.GG5675@tucnak.redhat.com> Cc: GCC Patches From: Andreas Tobler Message-ID: <565CA63D.4010602@fgznet.ch> Date: Mon, 30 Nov 2015 20:18:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151130162247.GG5675@tucnak.redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg03517.txt.bz2 On 30.11.15 17:22, Jakub Jelinek wrote: > On Mon, Nov 30, 2015 at 05:17:29PM +0100, Bernd Schmidt wrote: >> On 11/30/2015 01:12 PM, Andreas Tobler wrote: >>> On 30.11.15 11:28, Bernd Schmidt wrote: >>>> On 11/29/2015 08:32 PM, Andreas Tobler wrote: >>>>> -/* { dg-do run { target { *-*-linux* } } } */ >>>>> +/* { dg-do run { target { *-*-linux* *-*-freebsd* } } } */ >>>> >>>> I see a patch from you to add asan support to x86 freebsd, but what >>>> about other architectures? >>> >>> You mean because of the wildcard? I'll add them as I have time to port >>> them. >>> >>> For now they are UNSUPPORTED. >> >> Is that how they show up, or do you get FAILs on other FreeBSDs? > > This is inside of asan.exp, which is guarded with > check_effective_target_fsanitize_address > and therefore should not be run at all on non-asan targets. It manifests this way: /usr/local/bin/ld: cannot find libasan_preinit.o: No such file or directory /usr/local/bin/ld: cannot find -lasan collect2: error: ld returned 1 exit status Then it bails out and the asan tests are skipped. ... testsuite/gcc.dg/asan/asan.exp completed in 1 seconds ... There is no UNSUPPORTED in the log file. > I think the testsuite changes are fine, but it IMHO doesn't make sense to > commit it until the FreeBSD asan supports lands in (which is dependent on > the upstream libsanitizer change I believe). Once it happens, it can be > cherry-picked from there, the config/i386 part looks reasonable. I agree that it doesn't make much sense to commit for the public, but I'd have a patch less on the table ;) But, np problem at all. This is the cherry I'd like to pick once it has landed :) http://reviews.llvm.org/D15049 The part for lib/asan/asan_linux.cc. Thanks for the comments! Andreas