From: Jeff Law <law@redhat.com>
To: Andreas Tobler <andreast-list@fgznet.ch>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch] RFC asan support for i?86/x86_64-*freebsd*
Date: Mon, 30 Nov 2015 22:27:00 -0000 [thread overview]
Message-ID: <565CCC38.70703@redhat.com> (raw)
In-Reply-To: <565B77D2.1070803@fgznet.ch>
On 11/29/2015 03:10 PM, Andreas Tobler wrote:
> All,
>
> this patch adds support for asan for i?86/x86_64-*freebsd*.
>
> Test results can be found on the list.
>
> These modifications belong only to gcc. There is one modification to
> asan/asan_linux.cc, this one is sent upstream. Until this one is in, my
> patch is on hold.
>
> One thing to note, FreeBSD does not need to link against -ldl. That is
> why I added an extra config check.
>
> But nevertheless I'd like to get some comments on the patch.
>
> Thanks to Jakub and Dan McGregor.
>
> Thanks,
> Andreas
>
>
> 2015-11-29 Andreas Tobler <andreast@gcc.gnu.org>
>
> * config/i386/i386.h: Define two new macros:
> SUBTARGET_SHADOW_OFFSET_64 and SUBTARGET_SHADOW_OFFSET_32.
> * config/i386/i386.c (ix86_asan_shadow_offset): Use these macros.
> * config/i386/darwin.h: Override the SUBTARGET_SHADOW_OFFSET_64
> macro.
> * config/i386/freebsd.h: Override the SUBTARGET_SHADOW_OFFSET_64
> and the SUBTARGET_SHADOW_OFFSET_32 macro.
> * config/freebsd.h (LIBASAN_EARLY_SPEC): Define.
> (LIBTSAN_EARLY_SPEC): Likewise.
> (LIBLSAN_EARLY_SPEC): Likewise.
>
> 2015-11-29 Andreas Tobler <andreast@gcc.gnu.org>
>
> * configure.ac: Replace the hard-coded -ldl requirement for
> link_sanitizer_common with a configure time check for -ldl.
> * configure: Regenerate.
> * configure.tgt: Add x86_64- and i?86-*-freebsd* targets.
The configury bits are fine. Uros would own review on the x86 specific
changes.
jeff
next prev parent reply other threads:[~2015-11-30 22:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-29 23:34 Andreas Tobler
2015-11-30 22:27 ` Jeff Law [this message]
2015-12-01 12:22 Uros Bizjak
2015-12-01 20:33 ` Andreas Tobler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565CCC38.70703@redhat.com \
--to=law@redhat.com \
--cc=andreast-list@fgznet.ch \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).