[Patch AArch64] Fix typo in aarch64_builtin_reciprocal.

[Patch AArch64] Fix typo in aarch64_builtin_reciprocal.

[Ramana Radhakrishnan]

The patch to restructure builtin_reciprocals missed out an obvious ')'. Adjusted thusly and applied as obvious to trunk.

regards
Ramana


2015-12-01  Ramana Radhakrishnan  <ramana.radhakrishnan@arm.com>

        * config/aarch64/aarch64.c (aarch64_builtin_reciprocal): Fix typo.

Re: [Patch AArch64] Fix typo in aarch64_builtin_reciprocal.

[Jakub Jelinek]

On Tue, Dec 01, 2015 at 08:58:53AM +0000, Ramana Radhakrishnan wrote:
> The patch to restructure builtin_reciprocals missed out an obvious ')'. Adjusted thusly and applied as obvious to trunk.

Sorry for that.  Could you please also handle the gimple_call_internal_p
case, so that it actually returns the aarch64 builtin decls if
it is internal SQRT call with the right modes?  See the i386 and rs6000
builtins.  Haven't done that for aarch64, because it uses a helper function
defined somewhere else, so haven't been sure how you want it to look like.
> 
> 2015-12-01  Ramana Radhakrishnan  <ramana.radhakrishnan@arm.com>
> 
>         * config/aarch64/aarch64.c (aarch64_builtin_reciprocal): Fix typo.

	Jakub

Re: [Patch AArch64] Fix typo in aarch64_builtin_reciprocal.

[Ramana Radhakrishnan]

[-- Attachment #1: Type: text/plain, Size: 1000 bytes --]



On 01/12/15 09:04, Jakub Jelinek wrote:
> On Tue, Dec 01, 2015 at 08:58:53AM +0000, Ramana Radhakrishnan wrote:
>> The patch to restructure builtin_reciprocals missed out an obvious ')'. Adjusted thusly and applied as obvious to trunk.
> 
> Sorry for that.  Could you please also handle the gimple_call_internal_p
> case, so that it actually returns the aarch64 builtin decls if
> it is internal SQRT call with the right modes?  See the i386 and rs6000
> builtins.  Haven't done that for aarch64, because it uses a helper function
> defined somewhere else, so haven't been sure how you want it to look like.

Thanks for pointing this out. James - can you please take a look ?  I don't think I'll have the time to get to this today.

I just realized my patch wasn't attached to the previous mail - here it is FTR.

regards
Ramana


>>
>> 2015-12-01  Ramana Radhakrishnan  <ramana.radhakrishnan@arm.com>
>>
>>         * config/aarch64/aarch64.c (aarch64_builtin_reciprocal): Fix typo.
> 
> 	Jakub
> 

[-- Attachment #2: fixup.txt --]
[-- Type: text/plain, Size: 444 bytes --]

diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c
index b150283..88dbe15 100644
--- a/gcc/config/aarch64/aarch64.c
+++ b/gcc/config/aarch64/aarch64.c
@@ -7112,7 +7112,7 @@ aarch64_builtin_reciprocal (gcall *call)
 	   & AARCH64_EXTRA_TUNE_RECIP_SQRT))
     return NULL_TREE;
 
-  if (gimple_call_internal_p (call)
+  if (gimple_call_internal_p (call))
     return NULL_TREE;
 
   tree fndecl = gimple_call_fndecl (call);