From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82668 invoked by alias); 1 Dec 2015 09:53:20 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 82658 invoked by uid 89); 1 Dec 2015 09:53:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 01 Dec 2015 09:53:18 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9C0C849; Tue, 1 Dec 2015 01:52:57 -0800 (PST) Received: from [10.2.206.27] (e105545-lin.cambridge.arm.com [10.2.206.27]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4D92C3F267; Tue, 1 Dec 2015 01:53:16 -0800 (PST) Subject: Re: [Patch AArch64] Fix typo in aarch64_builtin_reciprocal. To: Jakub Jelinek References: <565D614D.9090009@foss.arm.com> <20151201090404.GS5675@tucnak.redhat.com> Cc: gcc-patches@gcc.gnu.org, James Greenhalgh From: Ramana Radhakrishnan Message-ID: <565D6E0B.1050602@foss.arm.com> Date: Tue, 01 Dec 2015 09:53:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151201090404.GS5675@tucnak.redhat.com> Content-Type: multipart/mixed; boundary="------------040508050907040801060701" X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg00056.txt.bz2 This is a multi-part message in MIME format. --------------040508050907040801060701 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Content-length: 1000 On 01/12/15 09:04, Jakub Jelinek wrote: > On Tue, Dec 01, 2015 at 08:58:53AM +0000, Ramana Radhakrishnan wrote: >> The patch to restructure builtin_reciprocals missed out an obvious ')'. Adjusted thusly and applied as obvious to trunk. > > Sorry for that. Could you please also handle the gimple_call_internal_p > case, so that it actually returns the aarch64 builtin decls if > it is internal SQRT call with the right modes? See the i386 and rs6000 > builtins. Haven't done that for aarch64, because it uses a helper function > defined somewhere else, so haven't been sure how you want it to look like. Thanks for pointing this out. James - can you please take a look ? I don't think I'll have the time to get to this today. I just realized my patch wasn't attached to the previous mail - here it is FTR. regards Ramana >> >> 2015-12-01 Ramana Radhakrishnan >> >> * config/aarch64/aarch64.c (aarch64_builtin_reciprocal): Fix typo. > > Jakub > --------------040508050907040801060701 Content-Type: text/plain; charset=UTF-8; name="fixup.txt" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="fixup.txt" Content-length: 444 diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c index b150283..88dbe15 100644 --- a/gcc/config/aarch64/aarch64.c +++ b/gcc/config/aarch64/aarch64.c @@ -7112,7 +7112,7 @@ aarch64_builtin_reciprocal (gcall *call) & AARCH64_EXTRA_TUNE_RECIP_SQRT)) return NULL_TREE; - if (gimple_call_internal_p (call) + if (gimple_call_internal_p (call)) return NULL_TREE; tree fndecl = gimple_call_fndecl (call); --------------040508050907040801060701--