From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128658 invoked by alias); 1 Dec 2015 11:57:43 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 128619 invoked by uid 89); 1 Dec 2015 11:57:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (146.101.78.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 01 Dec 2015 11:57:40 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-1-RF75R6M9RnivSxuYsO02Zg-1; Tue, 01 Dec 2015 11:57:32 +0000 Received: from [10.2.206.200] ([10.1.2.79]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Tue, 1 Dec 2015 11:57:32 +0000 Message-ID: <565D8B2C.2050501@arm.com> Date: Tue, 01 Dec 2015 11:57:00 -0000 From: Kyrill Tkachov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Christian Bruel , ramana.radhakrishnan@foss.arm.com CC: "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH, ARM] PR target/68617 Fix armv6 unaligned_access with attribute thumb References: <565D65E3.2060806@st.com> In-Reply-To: <565D65E3.2060806@st.com> X-MC-Unique: RF75R6M9RnivSxuYsO02Zg-1 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg00073.txt.bz2 Hi Christian, On 01/12/15 09:18, Christian Bruel wrote: > Hi, > > This patches fixes the PR my making the unaligned_access flag sensitive t= o the attribute target, since some armv6 might use unaligned loads dependin= g on the TARGET_32BIT flag. > > OK for stage3 ? > Index: gcc/testsuite/gcc.target/arm/attr-unaligned-load-ice.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- gcc/testsuite/gcc.target/arm/attr-unaligned-load-ice.c (revision 0) +++ gcc/testsuite/gcc.target/arm/attr-unaligned-load-ice.c (working copy) @@ -0,0 +1,19 @@ +/* PR target/68617 + Verify that unaligned_access is correctly with attribute target. */ +/* { dg-do compile } */ +/* { dg-skip-if "avoid conflicting multilib options" { *-*-* } { "-march= =3D*" } { "-march=3Darmv6" } } */ +/* { dg-options "-Os -mfloat-abi=3Dsoftfp -mtp=3Dsoft" } */ +/* { dg-add-options arm_arch_v6 } */ Do you need the -mtp=3Dsoft ? This is ok for trunk. Thanks for picking this up. Kyrill