public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Andreas Krebbel <krebbel@linux.vnet.ibm.com>
To: gcc-patches@gcc.gnu.org, vogt@linux.vnet.ibm.com
Cc: Ulrich Weigand <Ulrich.Weigand@de.ibm.com>
Subject: Re: [PATCH] S/390: Fix warning in "*movstr" pattern.
Date: Wed, 02 Dec 2015 08:59:00 -0000	[thread overview]
Message-ID: <565EB2DE.2050901@linux.vnet.ibm.com> (raw)
In-Reply-To: <20151130144537.GA21875@linux.vnet.ibm.com>

On 11/30/2015 03:45 PM, Dominik Vogt wrote:
> On Mon, Nov 09, 2015 at 01:33:23PM +0100, Andreas Krebbel wrote:
>> On 11/04/2015 02:39 AM, Dominik Vogt wrote:
>>> On Tue, Nov 03, 2015 at 06:47:28PM +0100, Ulrich Weigand wrote:
>>>> Dominik Vogt wrote:
+++ b/gcc/testsuite/gcc.target/s390/md/movstr-1.c
@@ -0,0 +1,11 @@
+/* Machine description pattern tests.  */
+
+/* { dg-do assemble } */
+/* { dg-options "-dP -save-temps" } */

-save-temps is not necessary for a dg-do assemble test.

+# Additional md torture tests.
+torture-init
+set MD_TEST_OPTS [list \
+	{-Os -march=z900} {-Os -march=z13} \
+	{-O0 -march=z900} {-O0 -march=z13} \
+	{-O1 -march=z900} {-O1 -march=z13} \
+	{-O2 -march=z900} {-O2 -march=z13} \
+	{-O3 -march=z900} {-O3 -march=z13}]
+set-torture-options $MD_TEST_OPTS
+gcc-dg-runtest [lsort [glob -nocomplain $md_tests]] "" $DEFAULT_CFLAGS
 torture-finish

Does it really make sense to use different -march options for the md/ tests? Whether a certain
pattern will match usually depends on the -march level. I would say the -march option needs to be
part of testcase.

-Andreas-

  reply	other threads:[~2015-12-02  8:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-03 17:17 Dominik Vogt
2015-11-03 17:47 ` Ulrich Weigand
2015-11-04  1:39   ` Dominik Vogt
2015-11-09 12:33     ` Andreas Krebbel
2015-11-30 14:48       ` Dominik Vogt
2015-12-02  8:59         ` Andreas Krebbel [this message]
2015-12-02  9:12           ` Dominik Vogt
2015-12-02 10:06             ` Dominik Vogt
2015-12-03 14:20               ` Dominik Vogt
2015-12-04 17:12                 ` Dominik Vogt
2015-12-11 11:20                   ` Andreas Krebbel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=565EB2DE.2050901@linux.vnet.ibm.com \
    --to=krebbel@linux.vnet.ibm.com \
    --cc=Ulrich.Weigand@de.ibm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=vogt@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).