From: Andreas Krebbel <krebbel@linux.vnet.ibm.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gcc-patches@gcc.gnu.org, vogt@linux.vnet.ibm.com
Subject: Re: S/390: Fix warnings in "*setmem_long..." patterns.
Date: Wed, 02 Dec 2015 13:19:00 -0000 [thread overview]
Message-ID: <565EEFBE.3090103@linux.vnet.ibm.com> (raw)
In-Reply-To: <565EEE13.3010405@linux.vnet.ibm.com>
On 12/02/2015 02:11 PM, Andreas Krebbel wrote:
> On 12/02/2015 01:51 PM, Ulrich Weigand wrote:
>> Andreas Krebbel wrote:
>>> On 12/02/2015 11:12 AM, Dominik Vogt wrote:
>>>> Hopefully, this is correct now; it does pass the functional test case
>>>> that's part of the patch. Unfortunately the define_insn patters
>>>> had to be duplicated because of the new subreg offsets.
>>>
>>> The number of patterns could possibly be reduced using the define_subst machinery. I'm looking into
>>> this for some other changes. No need to do this right now. We can do this later on-top.
>>
>> For this particular issue, shouldn't a simple mode_attr be OK?
>> I see that the sh port uses this:
>>
>> (define_mode_attr lowpart_be [(QI "3") (HI "2")])
>>
>> [(set (reg:SI T_REG)
>> (eq:SI
>> (subreg:QIHI
>> (and:SI (match_operand:SI 0 "arith_reg_operand")
>> (match_operand:SI 1 "arith_reg_operand")) <lowpart_be>)
>> (const_int 0)))]
>
> Unfortunately in our case the attribute value doesn't only depend on the mode. It also depends on
> zarch/esa. We would need some kind of conditional attribute.
However, we could probably at least merge the two zarch variants.
The define_subst is probably the right thing for adding the AND around the padding byte operand.
Bye,
-Andreas-
next prev parent reply other threads:[~2015-12-02 13:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 15:23 Dominik Vogt
2015-11-30 16:08 ` Andreas Krebbel
2015-11-30 17:12 ` Ulrich Weigand
2015-11-30 17:57 ` Andreas Krebbel
2015-12-01 10:00 ` Dominik Vogt
2015-12-01 13:54 ` Dominik Vogt
2015-12-02 10:12 ` Dominik Vogt
2015-12-02 11:44 ` Andreas Krebbel
2015-12-02 12:51 ` Ulrich Weigand
2015-12-02 13:11 ` Andreas Krebbel
2015-12-02 13:19 ` Andreas Krebbel [this message]
2015-12-04 17:16 ` Dominik Vogt
2015-12-11 11:19 ` Andreas Krebbel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565EEFBE.3090103@linux.vnet.ibm.com \
--to=krebbel@linux.vnet.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=uweigand@de.ibm.com \
--cc=vogt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).